Optimize beam scoring.

Optimize beam scoring.

Use a priority queue of scores.  This allows us to drop the arbitrary
reasonable_score threshold. On morgenlied.ly, this reduces the number
of scoring passes from 13.5k to 10.7k.

[hanwenn, 2011-02-03 02:40:02]

Please review.

[hanwenn, 2011-02-03 02:44:25]

regtest is clean.

On Thu, Feb 3, 2011 at 12:40 AM,  <hanwenn@gmail.com> wrote:
> Reviewers: ,
>
> Message:
>
> Please review.
>
>
>
> Description:
> Optimize beam scoring.
>
> Use a priority queue of scores.  This allows us to drop the arbitrary
> reasonable_score threshold. On morgenlied.ly, this reduces the number
> of scoring passes from 13.5k to 10.7k.
>
> Please review this at http://codereview.appspot.com/4129047/
>
> Affected files:
>  M lily/beam-quanting.cc
>  M lily/include/beam-scoring-problem.hh
>
>
>



-- 
Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen

[Graham Percival (old account), 2011-02-03 16:03:21]

I can confirm the clean regtest.

http://codereview.appspot.com/4129047/diff/1003/lily/beam-quanting.cc
File lily/beam-quanting.cc (left):

http://codereview.appspot.com/4129047/diff/1003/lily/beam-quanting.cc#oldcode249
lily/beam-quanting.cc:249: scores->clear ();
I have absolutely no knowledge of this code or algorithm, but are you certain
you want to delete this line?

[hanwenn, 2011-02-04 00:19:34]

On Thu, Feb 3, 2011 at 2:03 PM,  <percival.music.ca@gmail.com> wrote:
>
http://codereview.appspot.com/4129047/diff/1003/lily/beam-quanting.cc#oldcode249
> lily/beam-quanting.cc:249: scores->clear ();
> I have absolutely no knowledge of this code or algorithm, but are you
> certain you want to delete this line?

It doesn't really make a difference.  The function is called with an
empty vector anyway.

-- 
Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen