Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12)

Issue 4121058: code review 4121058: spec: fix Typeof() return type (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 3 months ago by niemeyer
Modified:
14 years, 3 months ago
Reviewers:
CC:
golang-dev, gri
Visibility:
Public.

Description

spec: fix Typeof() return type

Patch Set 1 #

Patch Set 2 : diff -r f37c651d8774 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f37c651d8774 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f37c651d8774 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 5 : diff -r f37c651d8774 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r bb3c8bb3f557 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M doc/go_spec.html View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7
niemeyer
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 3 months ago (2011-02-04 14:10:53 UTC) #1
gri
LGTM but please change the date. http://codereview.appspot.com/4121058/diff/6001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/4121058/diff/6001/doc/go_spec.html#newcode2 doc/go_spec.html:2: <!-- subtitle Version ...
14 years, 3 months ago (2011-02-04 16:57:08 UTC) #2
niemeyer
Done. PTAL
14 years, 3 months ago (2011-02-04 17:11:44 UTC) #3
gri
I am getting edit doc/go_spec.html: patch did not apply cleanly hgpatch failed (perhaps you are ...
14 years, 3 months ago (2011-02-04 17:23:28 UTC) #4
niemeyer
> (perhaps you are not synced with the latest spec change from this morning?) Uh, ...
14 years, 3 months ago (2011-02-04 17:26:34 UTC) #5
gri
LGTM thanks. - gri On Fri, Feb 4, 2011 at 9:26 AM, <n13m3y3r@gmail.com> wrote: > ...
14 years, 3 months ago (2011-02-04 17:28:58 UTC) #6
gri
14 years, 3 months ago (2011-02-04 17:29:10 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=75d6775388d8 ***

spec: fix Typeof() return type

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/4121058

Committer: Robert Griesemer <gri@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b