Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(158)

Issue 4119052: code review 4119052: gc: select receive bug fix (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 3 months ago by rsc
Modified:
14 years, 3 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

gc: select receive bug fix Affects receive using := when new variable escapes to heap. Fixes issue 1468.

Patch Set 1 #

Patch Set 2 : diff -r c45c540f43cb https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5072be258d5b https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2 lines) Patch
M src/cmd/gc/select.c View 1 2 chunks +2 lines, -2 lines 0 comments Download
A test/fixedbugs/bug320.go View 1 2 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 3 months ago (2011-02-02 23:34:08 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=26ff781f396e *** gc: select receive bug fix Affects receive using := when ...
14 years, 3 months ago (2011-02-02 23:34:11 UTC) #2
ken3
14 years, 3 months ago (2011-02-03 01:57:32 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b