Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(604)

Issue 4106041: code review 4106041: [68]l: more robust decoding of reflection type info in ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by lvd
Modified:
14 years, 10 months ago
Reviewers:
CC:
rsc, golang-dev, golang-dev_googlegroups.org
Visibility:
Public.

Description

[68]l: more robust decoding of reflection type info in generating dwarf.

Patch Set 1 #

Patch Set 2 : code review 4106041: [68]l: more robust decoding of reflection type info in ... #

Patch Set 3 : code review 4106041: [68]l: more robust decoding of reflection type info in ... #

Total comments: 1

Patch Set 4 : code review 4106041: [68]l: more robust decoding of reflection type info in ... #

Patch Set 5 : code review 4106041: [68]l: more robust decoding of reflection type info in ... #

Patch Set 6 : code review 4106041: [68]l: more robust decoding of reflection type info in ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -15 lines) Patch
M src/cmd/ld/dwarf.c View 1 2 3 4 5 6 chunks +29 lines, -15 lines 0 comments Download

Messages

Total messages: 3
lvd
Hello rsc (cc: golang-dev@googlegroups.com, golang-dev@googlegroups.org), I'd like you to review this change.
14 years, 10 months ago (2011-01-24 10:41:03 UTC) #1
rsc
LGTM http://codereview.appspot.com/4106041/diff/6001/src/cmd/ld/dwarf.c File src/cmd/ld/dwarf.c (right): http://codereview.appspot.com/4106041/diff/6001/src/cmd/ld/dwarf.c#newcode807 src/cmd/ld/dwarf.c:807: return (r == nil) ? nil : r->sym; ...
14 years, 10 months ago (2011-01-24 19:47:08 UTC) #2
lvd
14 years, 10 months ago (2011-01-24 19:59:45 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=071ff4fd4a8a ***

[68]l: more robust decoding of reflection type info in generating dwarf.

R=rsc
CC=golang-dev, golang-dev
http://codereview.appspot.com/4106041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b