Issue 4083043: code review 4083043: [568]c: remove pickle generation code.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4083043: code review 4083043: [568]c: remove pickle generation code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by lvd

Modified:
14 years, 5 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

cc: remove pickle generation code.

Patch Set 1 #

Patch Set 2 : code review 4083043: [568]c: remove pickle generation code. #

Patch Set 3 : code review 4083043: cc: remove pickle generation code. #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -311 lines)			Patch
M	src/cmd/cc/Makefile	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/cc/cc.h	View	1 2	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/cmd/cc/dcl.c	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/cmd/cc/lex.c	View		4 chunks	+3 lines, -5 lines	0 comments	Download
R	src/cmd/cc/pickle.c	View		1 chunk	+0 lines, -298 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

lvd

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 5 months ago (2011-01-21 16:54:43 UTC) #1

lvd

*** Submitted as http://code.google.com/p/go/source/detail?r=6d3e13473c6e *** cc: remove pickle generation code. R=rsc CC=golang-dev http://codereview.appspot.com/4083043

14 years, 5 months ago (2011-01-21 16:59:39 UTC) #3

lvd

14 years, 5 months ago (2011-01-21 17:00:39 UTC) #4

done and submitted.

On Fri, Jan 21, 2011 at 17:57, <rsc@golang.org> wrote:

> LGTM
>
> you can say "cc:" instead of "[568]c:".
>
>
>
> http://codereview.appspot.com/4083043/
>

Expand All Messages | Collapse All Messages