Issue 4081041: code review 4081041: net: avoid nil dereference if /etc/services can't be opened

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4081041: code review 4081041: net: avoid nil dereference if /etc/services can't be opened (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by cthom

Modified:
14 years, 5 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

net: avoid nil dereference if /etc/services can't be opened

Patch Set 1 #

Patch Set 2 : code review 4081041: net: avoid nil dereference if /etc/services can't be opened #

Patch Set 3 : code review 4081041: net: avoid nil dereference if /etc/services can't be opened #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/pkg/net/port.go	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

cthom

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 5 months ago (2011-01-19 14:36:32 UTC) #1

rsc

use a return statement to make this a 2-line change http://golang.org/doc/effective_go.html#if

14 years, 5 months ago (2011-01-19 14:39:41 UTC) #2

cthom

Hello golang-dev@googlegroups.com, rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 5 months ago (2011-01-19 14:48:48 UTC) #3

rsc

14 years, 5 months ago (2011-01-19 14:55:51 UTC) #5

*** Submitted as f815fb5175c5 ***

net: avoid nil dereference if /etc/services can't be opened

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/4081041

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages