Issue 4080059: Set filename of binary field on another field

ced

http://codereview.appspot.com/4080059/diff/1/tryton/gui/window/view_form/view/form_gtk/binary.py File tryton/gui/window/view_form/view/form_gtk/binary.py (right): http://codereview.appspot.com/4080059/diff/1/tryton/gui/window/view_form/view/form_gtk/binary.py#newcode80 tryton/gui/window/view_form/view/form_gtk/binary.py:80: name_wid = self.record.group.fields[self.file_name] Must test if record is set ...

13 years, 2 months ago (2011-02-07 19:16:51 UTC) #2

nicoe

http://codereview.appspot.com/4080059/diff/1/tryton/gui/window/view_form/view/form_gtk/binary.py File tryton/gui/window/view_form/view/form_gtk/binary.py (right): http://codereview.appspot.com/4080059/diff/1/tryton/gui/window/view_form/view/form_gtk/binary.py#newcode80 tryton/gui/window/view_form/view/form_gtk/binary.py:80: name_wid = self.record.group.fields[self.file_name] On 2011/02/07 19:16:51, ced wrote: > ...

13 years, 2 months ago (2011-02-08 12:08:35 UTC) #3

ced

http://codereview.appspot.com/4080059/diff/6002/tryton/gui/window/view_form/model/field.py File tryton/gui/window/view_form/model/field.py (right): http://codereview.appspot.com/4080059/diff/6002/tryton/gui/window/view_form/model/field.py#newcode6 tryton/gui/window/view_form/model/field.py:6: from StringIO import StringIO Not used. http://codereview.appspot.com/4080059/diff/6002/tryton/gui/window/view_form/model/field.py#newcode740 tryton/gui/window/view_form/model/field.py:740: class ...

13 years, 2 months ago (2011-02-08 22:34:00 UTC) #6

nicoe

http://codereview.appspot.com/4080059/diff/6002/tryton/gui/window/view_form/model/field.py File tryton/gui/window/view_form/model/field.py (right): http://codereview.appspot.com/4080059/diff/6002/tryton/gui/window/view_form/model/field.py#newcode6 tryton/gui/window/view_form/model/field.py:6: from StringIO import StringIO On 2011/02/08 22:34:01, ced wrote: ...

13 years, 2 months ago (2011-02-10 11:16:45 UTC) #7

ced

http://codereview.appspot.com/4080059/diff/14001/tryton/gui/window/view_form/view/form_gtk/binary.py File tryton/gui/window/view_form/view/form_gtk/binary.py (right): http://codereview.appspot.com/4080059/diff/14001/tryton/gui/window/view_form/view/form_gtk/binary.py#newcode42 tryton/gui/window/view_form/view/form_gtk/binary.py:42: self.widget.pack_start(self.wid_size, expand=not self.filename, fill=True) 80 cols

13 years, 2 months ago (2011-02-14 10:18:03 UTC) #9

nicoe

http://codereview.appspot.com/4080059/diff/14001/tryton/gui/window/view_form/view/form_gtk/binary.py File tryton/gui/window/view_form/view/form_gtk/binary.py (right): http://codereview.appspot.com/4080059/diff/14001/tryton/gui/window/view_form/view/form_gtk/binary.py#newcode42 tryton/gui/window/view_form/view/form_gtk/binary.py:42: self.widget.pack_start(self.wid_size, expand=not self.filename, fill=True) On 2011/02/14 10:18:03, ced wrote: ...

13 years, 2 months ago (2011-02-15 14:45:25 UTC) #10

ced

http://codereview.appspot.com/4080059/diff/18001/tryton/gui/window/view_form/view/form_gtk/binary.py File tryton/gui/window/view_form/view/form_gtk/binary.py (right): http://codereview.appspot.com/4080059/diff/18001/tryton/gui/window/view_form/view/form_gtk/binary.py#newcode40 tryton/gui/window/view_form/view/form_gtk/binary.py:40: if self.filename and self.filename_visible: Better to put the if ...

13 years, 2 months ago (2011-02-16 14:34:28 UTC) #12

LGTM

Sign in to reply to this message.

Issue 4080059: Set filename of binary field on another field (Closed)

Patch Set 1 #

Patch Set 2 : check for record presence #

Patch Set 3 : Added name entry to binary widget, image widget support for file_name #

Patch Set 4 : Support for filename_visible attribute & shortcut/focus handling #

Patch Set 5 : Fix 80 chars width #

Patch Set 6 : Do not create wid_text if unnecessary #

Messages