Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(281)

Issue 4079047: code review 4079047: time: Support Solaris zoneinfo directory. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by iant
Modified:
14 years, 10 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

time: Support Solaris zoneinfo directory.

Patch Set 1 #

Patch Set 2 : code review 4079047: time: Support Solaris zoneinfo directory. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/pkg/time/zoneinfo_unix.go View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 4
iant
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 10 months ago (2011-01-28 23:27:23 UTC) #1
iant
The issue here is that Solaris puts the zoneinfo files in /usr/share/lib/zoneinfo/, not /usr/share/zoneinfo. I'm ...
14 years, 10 months ago (2011-01-28 23:28:55 UTC) #2
rsc
LGTM
14 years, 10 months ago (2011-01-28 23:45:56 UTC) #3
iant
14 years, 10 months ago (2011-01-28 23:56:18 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=80e30fa58bd9 ***

time: Support Solaris zoneinfo directory.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4079047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b