code review 4077042: http: follow relative redirect in Get

http: follow relative redirect in Get

Fixes issue 1431.

[rsc, 2011-01-20 16:39:51]

Hello bradfitz (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[dangabrad, 2011-01-20 17:16:37]

LGTM
 On Jan 20, 2011 8:39 AM, <rsc@golang.org> wrote:
> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> http: follow relative redirect in Get
>
> Fixes issue 1431.
>
> Please review this at http://codereview.appspot.com/4077042/
>
> Affected files:
> M src/pkg/http/client.go
>
>
> Index: src/pkg/http/client.go
> ===================================================================
> --- a/src/pkg/http/client.go
> +++ b/src/pkg/http/client.go
> @@ -120,6 +120,7 @@
> // TODO: if/when we add cookie support, the redirected request shouldn't
> // necessarily supply the same cookies as the original.
> // TODO: set referrer header on redirects.
> + var base *URL
> for redirect := 0; ; redirect++ {
> if redirect >= 10 {
> err = os.ErrorString("stopped after 10 redirects")
> @@ -127,7 +128,12 @@
> }
>
> var req Request
> - if req.URL, err = ParseURL(url); err != nil {
> + if base == nil {
> + req.URL, err = ParseURL(url)
> + } else {
> + req.URL, err = base.ParseURL(url)
> + }
> + if err != nil {
> break
> }
> url = req.URL.String()
> @@ -140,6 +146,7 @@
> err = os.ErrorString(fmt.Sprintf("%d response missing Location
> header", r.StatusCode))
> break
> }
> + base = req.URL
> continue
> }
> finalURL = url
>
>

[rsc, 2011-01-20 17:50:29]

*** Submitted as e7c55b32ccc7 ***

http: follow relative redirect in Get

Fixes issue 1431.

R=bradfitz, dangabrad
CC=golang-dev
http://codereview.appspot.com/4077042