Issue 4073049: code review 4073049: 6g: fix registerization of temporaries

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4073049: code review 4073049: 6g: fix registerization of temporaries (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by ejsherry

Modified:
14 years, 4 months ago

Reviewers:

CC:
rsc, ken2, golang-dev

Visibility:
Public.

Description

6g: fix registerization of temporaries Use correct range in allocated register test.

Patch Set 1 #

Patch Set 2 : code review 4073049: 6g: fix registerization of temporaries #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/6g/gsubr.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

ejsherry

Hello rsc, ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 4 months ago (2011-02-01 15:55:55 UTC) #1

ejsherry

On 2011/02/01 15:57:59, rsc1 wrote: > Looks correct, but do you have a test case? ...

14 years, 4 months ago (2011-02-01 16:09:56 UTC) #3

rsc

14 years, 4 months ago (2011-02-01 17:12:44 UTC) #5

*** Submitted as 3b9b7b4a1eab ***

6g: fix registerization of temporaries

Use correct range in allocated register test.

R=rsc, ken2
CC=golang-dev
http://codereview.appspot.com/4073049

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages