Issue 4073048: Use queue for prioritizing slur scores.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4073048: Use queue for prioritizing slur scores. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by hanwenn

Modified:
13 years, 3 months ago

Reviewers:
Graham Percival (old account)

CC:
lilypond-devel_gnu.org, MikeSol

Visibility:
Public.

Description

Use queue for prioritizing slur scores. This drops the number of scoring passes for input/regression/slur-scoring.ly from 11.7k to 3.0k

Patch Set 1 #

Total comments: 1

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+136 lines, -112 lines)			Patch
M	lily/include/slur-configuration.hh	View	3 chunks	+29 lines, -13 lines	1 comment	Download
M	lily/include/slur-scoring.hh	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	lily/slur-configuration.cc	View	3 chunks	+46 lines, -7 lines	0 comments	Download
M	lily/slur-scoring.cc	View	6 chunks	+59 lines, -89 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Graham Percival (old account)

LGTM, and I can confirm clean regtest comparison. http://codereview.appspot.com/4073048/diff/1/lily/include/slur-configuration.hh File lily/include/slur-configuration.hh (right): http://codereview.appspot.com/4073048/diff/1/lily/include/slur-configuration.hh#newcode68 lily/include/slur-configuration.hh:68: friend ...

13 years, 3 months ago (2011-02-01 22:55:33 UTC) #2

hanwenn

13 years, 3 months ago (2011-02-02 01:22:03 UTC) #3

Thanks. Pushed.

On Tue, Feb 1, 2011 at 8:55 PM,  <percival.music.ca@gmail.com> wrote:
> LGTM, and I can confirm clean regtest comparison.
>
>
>
http://codereview.appspot.com/4073048/diff/1/lily/include/slur-configuration.hh
> File lily/include/slur-configuration.hh (right):
>
>
http://codereview.appspot.com/4073048/diff/1/lily/include/slur-configuration....
> lily/include/slur-configuration.hh:68: friend class
> Slur_configuration_less;
> Indent.
>
> http://codereview.appspot.com/4073048/
>



-- 
Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen

Expand All Messages | Collapse All Messages