Issue 4063042: code review 4063042: syscall: correct WSTOPPED on OS X

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4063042: code review 4063042: syscall: correct WSTOPPED on OS X (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by rsc

Modified:
14 years, 5 months ago

Reviewers:

CC:
r, r2, golang-dev

Visibility:
Public.

Description

syscall: correct WSTOPPED on OS X Have to set #defines correctly to get correct value. Otherwise get a mask for use in implementing WIFSTOPPED(status). Changed WSTOPPED definition in os because on OS X WSTOPPED and WUNTRACED have different values even though they seem to mean the same thing. Fixes issue 1374.

Patch Set 1 #

Patch Set 2 : code review 4063042: syscall: correct WSTOPPED on OS X #

Patch Set 3 : code review 4063042: syscall: correct WSTOPPED on OS X #

Patch Set 4 : code review 4063042: syscall: correct WSTOPPED on OS X #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -7 lines)			Patch
M	src/pkg/os/exec.go	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/pkg/syscall/mkerrors.sh	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/syscall/zerrors_darwin_386.go	View		4 chunks	+36 lines, -1 line	0 comments	Download
M	src/pkg/syscall/zerrors_darwin_amd64.go	View		4 chunks	+36 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 5 months ago (2011-01-18 18:25:23 UTC) #1

rsc

14 years, 5 months ago (2011-01-18 19:02:43 UTC) #3

*** Submitted as b5c0ac27d989 ***

syscall: correct WSTOPPED on OS X

Have to set #defines correctly to get correct value.
Otherwise get a mask for use in implementing WIFSTOPPED(status).

Changed WSTOPPED definition in os because on
OS X WSTOPPED and WUNTRACED have different values
even though they seem to mean the same thing.

Fixes issue 1374.

R=r, r2
CC=golang-dev
http://codereview.appspot.com/4063042

Expand All Messages | Collapse All Messages