Issue 4060043: code review 4060043: godoc: show line numbers for non-go files (bug fix)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4060043: code review 4060043: godoc: show line numbers for non-go files (bug fix) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by gri

Modified:
14 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

godoc: show line numbers for non-go files (bug fix) Also: Give line numbers a style and make them less intrusive.

Patch Set 1 #

Patch Set 2 : code review 4060043: godoc: show line numbers for non-go files (bug fix) #

Patch Set 3 : code review 4060043: godoc: show line numbers for non-go files (bug fix) #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	doc/all.css	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	src/cmd/godoc/format.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2011-01-20 18:41:48 UTC) #1

gri

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 3 months ago (2011-01-20 18:42:45 UTC) #2

gri

14 years, 3 months ago (2011-01-20 18:43:58 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=559f12e8fcd5 ***

godoc: show line numbers for non-go files (bug fix)

Also: Give line numbers a style and make them less intrusive.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4060043

Expand All Messages | Collapse All Messages