code review 4057042: regexp: throw an error on a bare ?

regexp: throw an error on a bare ?

Minor cleanup:
  - removed a duplicate test case
  - added a function to remove repeated code
  - for consistency, replaced "return nil" with a panic at an
    unreachable point

Fixes issue 1428

[benlynn, 2011-01-18 14:06:03]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r, 2011-01-18 19:12:00]

http://codereview.appspot.com/4057042/diff/2001/src/pkg/regexp/regexp.go
File src/pkg/regexp/regexp.go (right):

http://codereview.appspot.com/4057042/diff/2001/src/pkg/regexp/regexp.go#newc...
src/pkg/regexp/regexp.go:286: func (p *parser) checkbackslash() int {
s/checkbackslash/checkBackslash/ and at the uses, obviously

[r, 2011-01-18 19:12:24]

Please fill out the CLA as described in contribute.html

[benlynn, 2011-01-19 00:03:14]

Hello golang-dev@googlegroups.com, r (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2011-01-19 00:07:44]

LGTM

[rsc, 2011-01-19 18:47:05]

*** Submitted as f945ffd9fff1 ***

regexp: reject bare ?

Minor cleanup:
  - removed a duplicate test case
  - added a function to remove repeated code
  - for consistency, replaced "return nil" with a panic at an
    unreachable point

Fixes issue 1428.

R=golang-dev, r, rsc
CC=golang-dev
http://codereview.appspot.com/4057042

Committer: Russ Cox <rsc@golang.org>