upload,py: change --message to --title

Current usage of --message option is confusing. The message is not really a message (comment), but subject of an issue or a title of patch set. -s option for --subject is a more logical change, but it is already bound for --server.

--help before:
  Issue options:
    -d DESCRIPTION, --description=DESCRIPTION
                        Optional description when creating an issue.
    -f DESCRIPTION_FILE, --description_file=DESCRIPTION_FILE
                        Optional path of a file that contains the description
                        when creating an issue.
    -r REVIEWERS, --reviewers=REVIEWERS
                        Add reviewers (comma separated email addresses).
    --cc=CC             Add CC (comma separated email addresses).
    --private           Make the issue restricted to reviewers and those CCed

  Patch options:
    -m MESSAGE, --message=MESSAGE
                        A message to identify the patch. Will prompt if
                        omitted.
    -i ISSUE, --issue=ISSUE
                        Issue number to which to add. Defaults to new issue.
    --base_url=BASE_URL
                        Base repository URL (listed as "Base URL" when viewing

--help after:
  Issue options:
    -t TITLE, --title=TITLE
                        Title to identify a new patch or a new issue. Will
                        prompt if omitted.
    -d DESCRIPTION, --description=DESCRIPTION
                        Optional description when creating an issue.
    -f DESCRIPTION_FILE, --description_file=DESCRIPTION_FILE
                        Optional path of a file that contains the description
                        when creating an issue.
    -r REVIEWERS, --reviewers=REVIEWERS
                        Add reviewers (comma separated email addresses).
    --cc=CC             Add CC (comma separated email addresses).
    --private           Make the issue restricted to reviewers and those CCed

  Patch options:
    -i ISSUE, --issue=ISSUE
                        Issue number to which to add. Defaults to new issue.
    --base_url=BASE_URL
                        Base repository URL (listed as "Base URL" when viewing

[techtonik, 2011-01-17 16:48:49]

Updated description.

[imirkin_alum.mit.edu, 2011-01-17 17:59:32]

What's the point? People are used to -m already.

On Mon, Jan 17, 2011 at 11:48 AM,  <techtonik@gmail.com> wrote:
> Updated description.
>
> http://codereview.appspot.com/4055041/
>
> --
> You received this message because you are subscribed to the Google Groups
> "codereview-discuss" group.
> To post to this group, send email to codereview-discuss@googlegroups.com.
> To unsubscribe from this group, send email to
> codereview-discuss+unsubscribe@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/codereview-discuss?hl=en.
>
>



-- 
Ilia Mirkin
imirkin@alum.mit.edu

[kpy, 2011-01-17 18:37:43]

Doesn't the "-m" option conflate the message and the title?  As in, it
becomes the title the first time around, but then becomes the message on
subsequent updates to the code review.  I remember being confused by this at
first, and wrote a wrapper script to get around the problem.


—Ping
Google Crisis Response


On Mon, Jan 17, 2011 at 09:59, Ilia Mirkin <imirkin@alum.mit.edu> wrote:

> What's the point? People are used to -m already.
>
> On Mon, Jan 17, 2011 at 11:48 AM,  <techtonik@gmail.com> wrote:
> > Updated description.
> >
> > http://codereview.appspot.com/4055041/
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "codereview-discuss" group.
> > To post to this group, send email to codereview-discuss@googlegroups.com
> .
> > To unsubscribe from this group, send email to
> >
codereview-discuss+unsubscribe@googlegroups.com<codereview-discuss%2Bunsubscr...
> .
> > For more options, visit this group at
> > http://groups.google.com/group/codereview-discuss?hl=en.
> >
> >
>
>
>
> --
> Ilia Mirkin
> imirkin@alum.mit.edu
>
> --
> You received this message because you are subscribed to the Google Groups
> "codereview-discuss" group.
> To post to this group, send email to codereview-discuss@googlegroups.com.
> To unsubscribe from this group, send email to
>
codereview-discuss+unsubscribe@googlegroups.com<codereview-discuss%2Bunsubscr...
> .
> For more options, visit this group at
> http://groups.google.com/group/codereview-discuss?hl=en.
>
>

[imirkin_alum.mit.edu, 2011-01-17 18:40:25]

Not quite. For creating a new issue, it's the subject of the issue,
and when updating an issue, it's the subject of the patchset. In the
latter case, that doesn't even get included in the actual email
message.

Honestly, I also found these options confusing. Perhaps they could
stand a rethink of which options do what. But a simple rename seems
counterproductive.

On Mon, Jan 17, 2011 at 1:37 PM, Ka-Ping Yee <kpy@google.com> wrote:
> Doesn't the "-m" option conflate the message and the title?  As in, it
> becomes the title the first time around, but then becomes the message on
> subsequent updates to the code review.  I remember being confused by this at
> first, and wrote a wrapper script to get around the problem.
>
> —Ping
> Google Crisis Response
>
>
> On Mon, Jan 17, 2011 at 09:59, Ilia Mirkin <imirkin@alum.mit.edu> wrote:
>>
>> What's the point? People are used to -m already.
>>
>> On Mon, Jan 17, 2011 at 11:48 AM,  <techtonik@gmail.com> wrote:
>> > Updated description.
>> >
>> > http://codereview.appspot.com/4055041/
>> >
>> > --
>> > You received this message because you are subscribed to the Google
>> > Groups
>> > "codereview-discuss" group.
>> > To post to this group, send email to
>> > codereview-discuss@googlegroups.com.
>> > To unsubscribe from this group, send email to
>> > codereview-discuss+unsubscribe@googlegroups.com.
>> > For more options, visit this group at
>> > http://groups.google.com/group/codereview-discuss?hl=en.
>> >
>> >
>>
>>
>>
>> --
>> Ilia Mirkin
>> imirkin@alum.mit.edu
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "codereview-discuss" group.
>> To post to this group, send email to codereview-discuss@googlegroups.com.
>> To unsubscribe from this group, send email to
>> codereview-discuss+unsubscribe@googlegroups.com.
>> For more options, visit this group at
>> http://groups.google.com/group/codereview-discuss?hl=en.
>>
>
>



-- 
Ilia Mirkin
imirkin@alum.mit.edu

[Andi Albrecht, 2011-01-17 18:58:57]

On Mon, Jan 17, 2011 at 7:40 PM, Ilia Mirkin <imirkin@alum.mit.edu> wrote:
> Not quite. For creating a new issue, it's the subject of the issue,
> and when updating an issue, it's the subject of the patchset. In the
> latter case, that doesn't even get included in the actual email
> message.
>
> Honestly, I also found these options confusing. Perhaps they could
> stand a rethink of which options do what. But a simple rename seems
> counterproductive.

Agreed. As Ilia pointed out, even though the options are confusing at
first sight people are using them nonetheless (maybe some wrapper
scripts too). To me it was the same, first I was confused by the way
"-m" works, but now I like what it does: It sends the (short) message
that describes the review or change to the reviewers.

>
> On Mon, Jan 17, 2011 at 1:37 PM, Ka-Ping Yee <kpy@google.com> wrote:
>> Doesn't the "-m" option conflate the message and the title?  As in, it
>> becomes the title the first time around, but then becomes the message on
>> subsequent updates to the code review.  I remember being confused by this at
>> first, and wrote a wrapper script to get around the problem.
>>
>> —Ping
>> Google Crisis Response
>>
>>
>> On Mon, Jan 17, 2011 at 09:59, Ilia Mirkin <imirkin@alum.mit.edu> wrote:
>>>
>>> What's the point? People are used to -m already.
>>>
>>> On Mon, Jan 17, 2011 at 11:48 AM,  <techtonik@gmail.com> wrote:
>>> > Updated description.
>>> >
>>> > http://codereview.appspot.com/4055041/
>>> >
>>> > --
>>> > You received this message because you are subscribed to the Google
>>> > Groups
>>> > "codereview-discuss" group.
>>> > To post to this group, send email to
>>> > codereview-discuss@googlegroups.com.
>>> > To unsubscribe from this group, send email to
>>> > codereview-discuss+unsubscribe@googlegroups.com.
>>> > For more options, visit this group at
>>> > http://groups.google.com/group/codereview-discuss?hl=en.
>>> >
>>> >
>>>
>>>
>>>
>>> --
>>> Ilia Mirkin
>>> imirkin@alum.mit.edu
>>>
>>> --
>>> You received this message because you are subscribed to the Google Groups
>>> "codereview-discuss" group.
>>> To post to this group, send email to codereview-discuss@googlegroups.com.
>>> To unsubscribe from this group, send email to
>>> codereview-discuss+unsubscribe@googlegroups.com.
>>> For more options, visit this group at
>>> http://groups.google.com/group/codereview-discuss?hl=en.
>>>
>>
>>
>
>
>
> --
> Ilia Mirkin
> imirkin@alum.mit.edu
>

[techtonik, 2011-01-18 19:28:55]

Andi, -m doesn't add any messages. It sets patchset/issue subject. To add
message you need to login and manually enter it here.

1. on first submission
 -m, --message  gives an issue a title
 -d,            adds description to an issue
2. on issue update
 -m, --message  gives title to a patchset
 -d             ??? updates description ???

That's not a simple rename. I wanted to keep this patch simple, so the next
patch could reenable --message for actually sending messages to reviewers,
probably merging this option with --description. In the final version the help
screen should look like:

1. on first submission
 -t, --title   issue subject
 -m, --message issue description
 -F, --file    read description from file
2. on issue update
 -t, --title   patchset title
 -m, --message message to reviewers
 -F, --file    read message from file

(I've chosen -F for consistency with Subversion)

[techtonik, 2011-12-16 09:54:11]

Implemented as http://codereview.appspot.com/5476044/

Thanks everybody for feedback.