Issue 4049041: code review 4049041: Regenerate {descriptor,plugin}.pb.golden.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4049041: code review 4049041: Regenerate {descriptor,plugin}.pb.golden. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by dsymonds

Modified:
14 years, 10 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Regenerate {descriptor,plugin}.pb.golden.

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+147 lines, -66 lines)			Patch
M	compiler/descriptor/descriptor.pb.go	View	3 chunks	+8 lines, -3 lines	0 comments	Download
M	compiler/descriptor/descriptor.pb.golden	View	12 chunks	+126 lines, -53 lines	0 comments	Download
M	compiler/plugin/plugin.pb.go	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	compiler/plugin/plugin.pb.golden	View	4 chunks	+8 lines, -9 lines	0 comments	Download

Total messages: 3

dsymonds

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 10 months ago (2011-01-17 04:06:56 UTC) #1

dsymonds

14 years, 10 months ago (2011-01-18 22:30:38 UTC) #3

*** Submitted as c99f48ceda3c ***

Regenerate {descriptor,plugin}.pb.golden.

R=r
CC=golang-dev
http://codereview.appspot.com/4049041