code review 4047041: arm reg bug with address(variable)

arm reg bug with address(variable)

[ken3, 2011-01-16 23:25:12]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[ken3, 2011-01-16 23:25:18]

*** Submitted as http://code.google.com/p/go/source/detail?r=8daa95cbf1cf ***

arm reg bug with address(variable)

R=r
CC=golang-dev
http://codereview.appspot.com/4047041

[r2, 2011-01-16 23:56:53]

LGTM

On Jan 16, 2011, at 3:25 PM, ken@google.com wrote:

> Reviewers: r,
> 
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
> 
> I'd like you to review this change.
> 
> 
> Description:
> arm reg bug with address(variable)
> 
> Please review this at http://codereview.appspot.com/4047041/
> 
> Affected files:
>  M src/cmd/5g/reg.c
> 
> 
> Index: src/cmd/5g/reg.c
> ===================================================================
> --- a/src/cmd/5g/reg.c
> +++ b/src/cmd/5g/reg.c
> @@ -137,18 +137,16 @@
> 	uint32 vreg;
> 	Bits bit;
> 
> -return;
> -
> 	if(first == 0) {
> 		fmtinstall('Q', Qconv);
> 	}
> 	first++;
> 
> 	if(debug['K']) {
> -		if(first != 2)
> +		if(first != 1)
> 			return;
> -		debug['R'] = 2;
> -		debug['P'] = 2;
> +//		debug['R'] = 2;
> +//		debug['P'] = 2;
> 		print("optimizing %S\n", curfn->nname->sym);
> 	}
> 
> @@ -644,21 +642,17 @@
> 		print("type %d %d %D\n", t, a->name, a);
> 		goto none;
> 
> -	case D_CONST:
> -		if(a->reg != NREG)
> -			r->regu |= RtoB(a->reg);
> -		// fallthrough
> -
> 	case D_NONE:
> 	case D_FCONST:
> 	case D_BRANCH:
> -		goto none;
> +		break;
> 
> 	case D_REGREG:
> 		if(a->offset != NREG)
> 			r->regu |= RtoB(a->offset);
> 		// fallthrough
> 
> +	case D_CONST:
> 	case D_REG:
> 	case D_SHIFT:
> 	case D_OREG:
> @@ -750,22 +744,8 @@
> 	if(n == D_PARAM)
> 		for(z=0; z<BITS; z++)
> 			params.b[z] |= bit.b[z];
> -
> -//	if(t == D_CONST) {
> -//		if(s == S) {
> -//			for(z=0; z<BITS; z++)
> -//				consts.b[z] |= bit.b[z];
> -//			return bit;
> -//		}
> -//		if(et != TARRAY)
> -//			for(z=0; z<BITS; z++)
> -//				addrs.b[z] |= bit.b[z];
> -//		for(z=0; z<BITS; z++)
> -//			params.b[z] |= bit.b[z];
> -//		return bit;
> -//	}
> -//	if(t != D_OREG)
> -//		goto none;
> +	if(t == D_CONST)
> +		setaddrs(bit);
> 
> 	return bit;
> 
> 
>