code review 4035042: gc: fix typed constant declarations

gc: fix typed constant declarations

Fixes issue 1411.

[ality, 2011-01-15 12:12:33]

Hello rsc, gri (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2011-01-15 16:21:32]

There should be a test.

On Sat, Jan 15, 2011 at 07:12,  <ality@pbrane.org> wrote:
> Reviewers: rsc, gri,
>
> Message:
> Hello rsc, gri (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> gc: fix typed constant declarations
>
> Fixes issue 1411.
>
> Please review this at http://codereview.appspot.com/4035042/
>
> Affected files:
>  M src/cmd/gc/walk.c
>
>
> Index: src/cmd/gc/walk.c
> ===================================================================
> --- a/src/cmd/gc/walk.c
> +++ b/src/cmd/gc/walk.c
> @@ -269,6 +269,8 @@
>                }
>                t = n->type;
>                if(t != T) {
> +                       if(!isideal(e->type) && !eqtype(t, e->type))
> +                               yyerror("const initializer must be type %T",
> t);
>                        convlit(&e, t);
>                        if(!okforconst[t->etype])
>                                yyerror("invalid constant type %T", t);
>
>
>

[ality, 2011-01-16 01:06:04]

Hello rsc, gri (cc: golang-dev@googlegroups.com),

Please take another look.

[ejsherry, 2011-01-17 19:12:33]

http://codereview.appspot.com/4035042/diff/10001/src/cmd/gc/walk.c
File src/cmd/gc/walk.c (right):

http://codereview.appspot.com/4035042/diff/10001/src/cmd/gc/walk.c#newcode273
src/cmd/gc/walk.c:273: yyerror("const initializer must be type %T", t);
How about including the type and value of e ("%+N") so the error is similar to
that for "var _ int = uint(0)"?

Also, "goto ret;" after recording the error to avoid giving e's type to n.

[ality, 2011-01-18 02:41:15]

Hello rsc, gri, ejsherry (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-01-18 15:03:54]

LGTM

[rsc, 2011-01-18 16:24:51]

*** Submitted as 41f50daef3ac ***

gc: fix typed constant declarations

Fixes issue 1411.

R=rsc, gri, ejsherry
CC=golang-dev
http://codereview.appspot.com/4035042

Committer: Russ Cox <rsc@golang.org>