Issue 4031043: Add the Instrument_name_engraver also to all group contexts

Issue 4031043: Add the Instrument_name_engraver also to all group contexts (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by Reinhold

Modified:
13 years, 3 months ago

Reviewers:
pkx166h, Graham Percival (old account), Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Implemented all suggested changes and pushed to master.

Patch Set 2 : Update the docs, too #

Total comments: 1

Patch Set 3 : Fix typo in FiguredBass #

Total comments: 8

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -5 lines)			Patch
M	Documentation/notation/staff.itely	View	1 2	2 chunks	+3 lines, -2 lines	1 comment	Download
A	input/regression/instrument-name-groups.ly	View		1 chunk	+42 lines, -0 lines	7 comments	Download
M	ly/engraver-init.ly	View		4 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

pkx166h

http://codereview.appspot.com/4031043/diff/2001/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4031043/diff/2001/Documentation/notation/staff.itely#newcode939 Documentation/notation/staff.itely:939: @code{ChordNames}, @code{Fretboards}, or @code{FiguredBas}), two 's' in @code{FiguredBass}

13 years, 3 months ago (2011-01-25 17:17:51 UTC) #1

Graham Percival (old account)

LGTM. http://codereview.appspot.com/4031043/diff/7001/input/regression/instrument-name-groups.ly File input/regression/instrument-name-groups.ly (right): http://codereview.appspot.com/4031043/diff/7001/input/regression/instrument-name-groups.ly#newcode32 input/regression/instrument-name-groups.ly:32: % TODO: Nested groups inherit the instrument name ...

13 years, 3 months ago (2011-01-26 19:01:47 UTC) #2

Neil Puttock

13 years, 3 months ago (2011-01-27 22:19:51 UTC) #3

http://codereview.appspot.com/4031043/diff/7001/Documentation/notation/staff....
File Documentation/notation/staff.itely (right):

http://codereview.appspot.com/4031043/diff/7001/Documentation/notation/staff....
Documentation/notation/staff.itely:939: @code{ChordNames}, @code{Fretboards}, or
@code{FiguredBass}),
Already added to FretBoards.

http://codereview.appspot.com/4031043/diff/7001/input/regression/instrument-n...
File input/regression/instrument-name-groups.ly (right):

http://codereview.appspot.com/4031043/diff/7001/input/regression/instrument-n...
input/regression/instrument-name-groups.ly:2: \header{
\header {

http://codereview.appspot.com/4031043/diff/7001/input/regression/instrument-n...
input/regression/instrument-name-groups.ly:17: \new StaffGroup \with {
instrumentName = "StaffGroup" } <<
#"StaffGroup"

etc.

http://codereview.appspot.com/4031043/diff/7001/input/regression/instrument-n...
input/regression/instrument-name-groups.ly:24: \new Staff { c''4 }
trailing whitespace

http://codereview.appspot.com/4031043/diff/7001/input/regression/instrument-n...
input/regression/instrument-name-groups.ly:25: \new Staff { c''4 }
trailing whitespace

http://codereview.appspot.com/4031043/diff/7001/input/regression/instrument-n...
input/regression/instrument-name-groups.ly:26: \new Staff { c''4 }
trailing whitespace

http://codereview.appspot.com/4031043/diff/7001/input/regression/instrument-n...
input/regression/instrument-name-groups.ly:32: % TODO: Nested groups inherit the
instrument name from the parent group,
set instrumentName/shortInstrumentName in engraver-init.ly

(see entry for Staff)

Expand All Messages | Collapse All Messages