Issue 4027042: Port the following ibus-1.3 patches to 1.4.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4027042: Port the following ibus-1.3 patches to 1.4. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by Yusuke Sato

Modified:
13 years, 3 months ago

Reviewers:
shawn.p.huang, Peng Huang

CC:
satorux

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Port the following ibus-1.3 patches to 1.4. o Temporary fix for a race condition between ibus_config_set_value("preload_engines") and ibus_bus_set_global_engine() https://github.com/ibus/ibus/commit/0f8cc67a33d4c0e1257a016de659f7e7a603bd62 o Fix potential race condition between ibus_config_set_value("preload_engines") and ibus_bus_list_active_engines() https://github.com/ibus/ibus/commit/c7b03330bdb297c9601c83c3ac041661e04fecd3 o Do not block the connection between ibus-daemon and ibus-memconf. https://github.com/ibus/ibus/commit/8df70865024aeab9950ecfcb5a34d45ec012878b Original patches are by Peng Huang and Yusuke Sato. BUG=http://crosbug.com/11032 TEST=see the bug

Patch Set 1 #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -1 line)			Patch
	M	bus/ibusimpl.c	View		5 chunks	+55 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Yusuke Sato

This change is for chromeos branch of ibus. Please let me know if you know ...

13 years, 3 months ago (2011-01-18 12:48:23 UTC) #1

Peng

On 2011/01/18 12:48:23, Yusuke Sato wrote: > This change is for chromeos branch of ibus. ...

13 years, 3 months ago (2011-01-18 14:30:15 UTC) #2

Yusuke Sato

13 years, 3 months ago (2011-01-19 01:07:09 UTC) #3

yes, it's for chromeos branch. submitted.

On 2011/01/18 14:30:15, Shawn.P.Huang wrote:
> On 2011/01/18 12:48:23, Yusuke Sato wrote:
> > This change is for chromeos branch of ibus. Please let me know if you know a
> > better way to fix the race issue.
> 
> If it is for chromeos branch, LGTM. Thanks.

Expand All Messages | Collapse All Messages