Issue 4026041: code review 4026041: cgo: In _cgo_main.c define all provided symbols as func...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4026041: code review 4026041: cgo: In _cgo_main.c define all provided symbols as func... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by iant

Modified:
14 years, 5 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

cgo: In _cgo_main.c define all provided symbols as functions. This defines crosscall2 in a way that matches that real definition, and also defines _cgo_allocate and _cgo_panic to indicate that they are available to be called by code compiled with gcc.

Patch Set 1 #

Patch Set 2 : code review 4026041: cgo: In _cgo_main.c define all provided symbols as func... #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/cmd/cgo/out.go	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 5 months ago (2011-01-14 18:30:25 UTC) #1

iant

14 years, 5 months ago (2011-01-14 18:52:11 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=4ec4bb5bc2a2 ***

cgo: In _cgo_main.c define all provided symbols as functions.

This defines crosscall2 in a way that matches that real
definition, and also defines _cgo_allocate and _cgo_panic to
indicate that they are available to be called by code compiled
with gcc.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4026041

Expand All Messages | Collapse All Messages