code review 4009043: misc: Import/Drop commands for Vim

misc: Import/Drop commands for Vim

New ftplugin adds Import and Drop commands for Go buffers
in Vim.  These commands ensure that the provided package is
imported (or not imported) in the current Go buffer, using
proper style and ordering, without moving the cursor.

E.g.

    :Import strings
    :ImportAs . strings
    :Drop strings

Two mappings are also introduced to help with the fmt package:

    \f => :Import fmt
    \F => :Drop fmt

[niemeyer, 2011-01-24 13:58:34]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2011-01-24 18:51:32]

R=adg

[adg, 2011-01-25 00:48:40]

Really cool plugin, thanks!

http://codereview.appspot.com/4009043/diff/6001/misc/vim/readme.txt
File misc/vim/readme.txt (right):

http://codereview.appspot.com/4009043/diff/6001/misc/vim/readme.txt#newcode29
misc/vim/readme.txt:29: In addition to syntax highlighting, there also filetype
plugins available
Replace this paragraph with something that describes what the filetype plugins
are (but there's only one at the moment?), or drop it entirely.

http://codereview.appspot.com/4009043/diff/6001/misc/vim/readme.txt#newcode32
misc/vim/readme.txt:32: To install these plguins:
s/plgu/plug/

http://codereview.appspot.com/4009043/diff/6001/misc/vim/readme.txt#newcode34
misc/vim/readme.txt:34: 1. Copy or link the filetype detection script to the
ftdetect directory
1. Step 1 as above.

[niemeyer, 2011-01-25 01:28:27]

All done, please take another look.

[adg, 2011-01-25 01:36:25]

*** Submitted as http://code.google.com/p/go/source/detail?r=cec205247d83 ***

misc: Import/Drop commands for Vim

New ftplugin adds Import and Drop commands for Go buffers
in Vim.  These commands ensure that the provided package is
imported (or not imported) in the current Go buffer, using
proper style and ordering, without moving the cursor.

E.g.

    :Import strings
    :ImportAs . strings
    :Drop strings

Two mappings are also introduced to help with the fmt package:

    \f => :Import fmt
    \F => :Drop fmt

R=adg
CC=golang-dev
http://codereview.appspot.com/4009043

Committer: Andrew Gerrand <adg@golang.org>

[adg, 2011-01-25 01:36:45]

LGTM

On 25 January 2011 11:28,  <n13m3y3r@gmail.com> wrote:
> All done, please take another look.
>
> http://codereview.appspot.com/4009043/
>