code review 4001056: gotest: enable unit tests for cmd directories

gotest: enable unit tests for cmd directories

[rsc, 2011-02-03 19:17:43]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg

[r, 2011-02-03 19:25:43]

looks reasonable.
i'm beginning to worry that it's doing too much work - running too many commands
- for a shell script

http://codereview.appspot.com/4001056/diff/5001/src/cmd/gotest/gotest
File src/cmd/gotest/gotest (right):

http://codereview.appspot.com/4001056/diff/5001/src/cmd/gotest/gotest#newcode167
src/cmd/gotest/gotest:167: # Renamed package named main to __main__ during
import above.
you use this comment twice and i found it hard to read both times. how about.
# The package "main" has been renamed "__main__" when imported. Adjust its uses.
also i think this could be a shell function

http://codereview.appspot.com/4001056/diff/5001/src/cmd/gotest/gotest#newcode173
src/cmd/gotest/gotest:173: # The command makes the multiline declaration
s/command/comment/ ?

[rsc, 2011-02-03 19:32:43]

Hello r (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2011-02-03 19:35:34]

LGTM

but if this grows much more, i may try a different approach. gotest often takes
more time than the binary does to compile, link, and run.

[rsc, 2011-02-03 19:54:00]

> but if this grows much more, i may try a different approach. gotest
> often takes more time than the binary does to compile, link, and run.

I don't think we're quite to that point yet but
it does appear to be significant.  Run in pkg/math
(many tests many source files) the gotest overhead
is about 0.7 seconds, or 35%.

0.57u 0.03s 0.61r 	 gomake testpackage GOTESTFILES=exp_test.go
hypot_test.go sqrt_test.go
0.30u 0.03s 0.34r 	 6g -I _test -o _xtest_.6 ...
0.20u 0.04s 0.25r 	 6l -L _test _testmain.6
PASS
0.00u 0.00s 0.02r 	 ./6.out
1.26u 0.68s 1.90r 	 ./gotest

[rsc, 2011-02-03 19:54:05]

*** Submitted as ec846dd8ce65 ***

gotest: enable unit tests for cmd directories

R=r
CC=golang-dev
http://codereview.appspot.com/4001056