Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(634)

Issue 4001049: code review 4001049: cgo: fix _cgo_run timestamp file order (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by niemeyer
Modified:
14 years, 4 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

cgo: fix _cgo_run timestamp file order The timestamp file is being created before cgo runs, which means errors will not prevent it from being created and thus will cause the build to break by rendering the rule up-to-date when it isn't.

Patch Set 1 #

Patch Set 2 : code review 4001049: cgo: fix _cgo_run timestamp file order #

Patch Set 3 : code review 4001049: cgo: fix _cgo_run timestamp file order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/Make.pkg View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
niemeyer
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 4 months ago (2011-02-01 22:10:04 UTC) #1
rsc
While you're there, might as well drop the @ sign. No point in hiding just ...
14 years, 4 months ago (2011-02-01 22:13:14 UTC) #2
niemeyer
Cool, done.
14 years, 4 months ago (2011-02-01 22:42:45 UTC) #3
rsc
LGTM
14 years, 4 months ago (2011-02-03 03:37:22 UTC) #4
rsc
14 years, 4 months ago (2011-02-03 03:37:42 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=40e087c35a69 ***

cgo: fix _cgo_run timestamp file order

The timestamp file is being created before cgo
runs, which means errors will not prevent it
from being created and thus will cause the
build to break by rendering the rule up-to-date
when it isn't.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4001049

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b