Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(47)

Issue 4000054: code review 4000054: fmt: rename internal interfaces (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 7 months ago by gri
Modified:
14 years, 7 months ago
Reviewers:
CC:
r, rsc, golang-dev
Visibility:
Public.

Description

fmt: rename internal interfaces readRuner -> runeReader unreadRuner -> runeUnreader

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r 6cd55df406ad https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c45c540f43cb https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -21 lines) Patch
M src/pkg/fmt/scan.go View 1 5 chunks +14 lines, -21 lines 0 comments Download

Messages

Total messages: 5
gri
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 7 months ago (2011-02-02 21:56:52 UTC) #1
rsc
On Wed, Feb 2, 2011 at 16:56, <gri@golang.org> wrote: > +type runeReader interface { > ...
14 years, 7 months ago (2011-02-02 21:59:37 UTC) #2
r
LGTM http://codereview.appspot.com/4000054/diff/1/src/pkg/fmt/scan.go File src/pkg/fmt/scan.go (right): http://codereview.appspot.com/4000054/diff/1/src/pkg/fmt/scan.go#newcode23 src/pkg/fmt/scan.go:23: io.RuneReader i agree this could just be deleted. ...
14 years, 7 months ago (2011-02-02 22:52:24 UTC) #3
gri
On Wed, Feb 2, 2011 at 2:52 PM, <r@golang.org> wrote: > LGTM > > > ...
14 years, 7 months ago (2011-02-02 22:57:00 UTC) #4
gri
14 years, 7 months ago (2011-02-02 23:00:17 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=5072be258d5b ***

fmt: rename internal interfaces

readRuner -> runeReader
unreadRuner -> runeUnreader

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/4000054
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b