LGTM - gri On Thu, Jan 20, 2011 at 8:35 AM, <rsc@golang.org> wrote: > Reviewers: ...
14 years, 5 months ago
(2011-01-20 16:41:08 UTC)
#2
LGTM
- gri
On Thu, Jan 20, 2011 at 8:35 AM, <rsc@golang.org> wrote:
> Reviewers: r,
>
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> unsafe: add missing case to doc for Pointer
>
> Fixes issue 1433.
>
> Please review this at http://codereview.appspot.com/3999047/
>
> Affected files:
> M src/pkg/unsafe/unsafe.go
>
>
> Index: src/pkg/unsafe/unsafe.go
> ===================================================================
> --- a/src/pkg/unsafe/unsafe.go
> +++ b/src/pkg/unsafe/unsafe.go
> @@ -14,8 +14,9 @@
> // Pointer represents a pointer to an arbitrary type. There are three
> special operations
> // available for type Pointer that are not available for other types.
> // 1) A pointer value of any type can be converted to a Pointer.
> -// 2) A uintptr can be converted to a Pointer.
> -// 3) A Pointer can be converted to a uintptr.
> +// 2) A Pointer can be converted to a pointer value of any type.
> +// 3) A uintptr can be converted to a Pointer.
> +// 4) A Pointer can be converted to a uintptr.
> // Pointer therefore allows a program to defeat the type system and read
> and write
> // arbitrary memory. It should be used with extreme care.
> type Pointer *ArbitraryType
>
>
>
*** Submitted as 98e2b498c901 *** unsafe: add missing case to doc for Pointer Fixes issue ...
14 years, 5 months ago
(2011-01-20 17:50:52 UTC)
#3
*** Submitted as 98e2b498c901 ***
unsafe: add missing case to doc for Pointer
Fixes issue 1433.
R=r, gri
CC=golang-dev
http://codereview.appspot.com/3999047
Issue 3999047: code review 3999047: unsafe: add missing case to doc for Pointer
(Closed)
Created 14 years, 5 months ago by rsc
Modified 14 years, 5 months ago
Reviewers:
Base URL:
Comments: 0