Use request.is_secure instead of HTTPS variable

Checking for HTTPS with environment variable provides unreliable detection of https connection. For example, Apache2 HTTPS is set to '1' instead of standard 'on' value when mod_wsgi is active https://issues.apache.org/bugzilla/show_bug.cgi?id=50581#c6

So it is better to use Django facilities.

[Andi Albrecht, 2011-01-14 06:38:33]

Are you sure that this is the right code base for this change?

IMO we shouldn't maintain settings for other environments than App Engine/Google
Apps here.

[techtonik, 2011-01-14 11:25:11]

You're right. We should use Django native code where possible.

http://docs.djangoproject.com/en/dev/ref/request-response/#django.http.HttpRe...

[Andi Albrecht, 2011-01-14 12:32:44]

On 2011/01/14 11:25:11, techtonik wrote:
> You're right. We should use Django native code where possible.
> 
>
http://docs.djangoproject.com/en/dev/ref/request-response/#django.http.HttpRe...

Now I'm somewhat confused. django.http.HttpRequest.is_secure does the same as
the original code:

def is_secure(self):
  return os.environ.get("HTTPS") == "on"

[techtonik, 2011-01-14 14:41:48]

On 2011/01/14 12:32:44, Andi Albrecht wrote:
>
> Now I'm somewhat confused. django.http.HttpRequest.is_secure does the same as
> the original code:
> 
> def is_secure(self):
>   return os.environ.get("HTTPS") == "on"

Look at django.http.WSGIRequest instead.
http://code.djangoproject.com/browser/django/branches/releases/1.1.X/django/c...

It uses different approach and I suspect I know why.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50581#c6

[Andi Albrecht, 2011-01-14 15:04:23]

On Fri, Jan 14, 2011 at 3:41 PM,  <techtonik@gmail.com> wrote:
> On 2011/01/14 12:32:44, Andi Albrecht wrote:
>
>> Now I'm somewhat confused. django.http.HttpRequest.is_secure does the
>
> same as
>>
>> the original code:
>
>> def is_secure(self):
>>   return os.environ.get("HTTPS") == "on"
>
> Look at django.http.WSGIRequest instead.
>
http://code.djangoproject.com/browser/django/branches/releases/1.1.X/django/c...

ah, sorry, I've missed the WSGI part again :)

LGTM then!

>
> It uses different approach and I suspect I know why.
> https://issues.apache.org/bugzilla/show_bug.cgi?id=50581#c6
>
> http://codereview.appspot.com/3996041/
>

[techtonik, 2011-01-14 15:49:55]

Thanks. Committed in r650. =)