Issue 3994045: Fix 1472 ensure space for KeySignature

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3994045: Fix 1472 ensure space for KeySignature (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by Keith

Modified:
13 years, 3 months ago

Reviewers:
Graham Percival (old account), hanwenn

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fix 1472 ensure space for KeySignature Ensure that the extent of keysignature is computed in time to influence note spacing by adding key-signature-interface::print to pure-print-callbacks

Patch Set 1 #

Patch Set 2 : white space #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	A	input/regression/key-signature-space.ly	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
	M	scm/define-grobs.scm	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

hanwenn

13 years, 3 months ago (2011-01-31 11:23:13 UTC) #2

LGTM

please make description more explicit.  How about

 "Add key-signature-interface::print to pure-print-callbacks"

Expand All Messages | Collapse All Messages