Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1174)

Issue 3992042: Implement compound time signatures (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by Reinhold
Modified:
13 years, 3 months ago
Reviewers:
carl.d.sorensen, Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Implement compound time signatures \compoundMeter is a replacement for \time, allowing complex time signatures (like (1+3)/8 or 3/8+(2+5)/16, etc.). The argument to the music function is a list of lists, each describing one fraction in the signature.

Patch Set 1 #

Total comments: 16
Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -103 lines) Patch
M Documentation/changes.tely View 1 chunk +14 lines, -0 lines 2 comments Download
A input/regression/compound-time-signatures.ly View 1 chunk +44 lines, -0 lines 1 comment Download
M ly/music-functions-init.ly View 1 chunk +27 lines, -0 lines 3 comments Download
M scm/time-signature-settings.scm View 1 chunk +103 lines, -0 lines 10 comments Download
M scripts/musicxml2ly.py View 2 chunks +0 lines, -103 lines 0 comments Download

Messages

Total messages: 2
Carl
LGTM. Thanks, Carl
13 years, 3 months ago (2011-01-14 22:45:57 UTC) #1
Neil Puttock
13 years, 3 months ago (2011-01-23 17:52:09 UTC) #2
http://codereview.appspot.com/3992042/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):

http://codereview.appspot.com/3992042/diff/1/Documentation/changes.tely#newco...
Documentation/changes.tely:77: c c c c c c c
c8

http://codereview.appspot.com/3992042/diff/1/Documentation/changes.tely#newco...
Documentation/changes.tely:79: c c c c c c c4 c8 c c
c8

http://codereview.appspot.com/3992042/diff/1/input/regression/compound-time-s...
File input/regression/compound-time-signatures.ly (right):

http://codereview.appspot.com/3992042/diff/1/input/regression/compound-time-s...
input/regression/compound-time-signatures.ly:20: \repeat unfold 10 c8 \repeat
unfold 20 c16\break
c16 \break

etc.

http://codereview.appspot.com/3992042/diff/1/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/3992042/diff/1/ly/music-functions-init.ly#newco...
ly/music-functions-init.ly:219: "Create compound time signatures. The argument
is a Scheme list of "
indent

(_i "one long docstring")

splitting the description up into separate strings means they're all discarded
apart from the first one:

#(display
  (procedure-documentation
   (ly:music-function-extract compoundMeter)))

-> Create compound time signatures. The argument is a Scheme list of

http://codereview.appspot.com/3992042/diff/1/ly/music-functions-init.ly#newco...
ly/music-functions-init.ly:234: \once \override Staff.TimeSignature #'stencil =
#ly:text-interface::print
#(lambda (grob)
   (grob-interpret-markup grob (format-compound-time $args)))

http://codereview.appspot.com/3992042/diff/1/ly/music-functions-init.ly#newco...
ly/music-functions-init.ly:235: \once \override Staff.TimeSignature #'text =
#(format-compound-time $args)
remove

http://codereview.appspot.com/3992042/diff/1/scm/time-signature-settings.scm
File scm/time-signature-settings.scm (right):

http://codereview.appspot.com/3992042/diff/1/scm/time-signature-settings.scm#...
scm/time-signature-settings.scm:309:
;%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
;;;

etc.

http://codereview.appspot.com/3992042/diff/1/scm/time-signature-settings.scm#...
scm/time-signature-settings.scm:313: (let* ((ll (reverse l)))
let

http://codereview.appspot.com/3992042/diff/1/scm/time-signature-settings.scm#...
scm/time-signature-settings.scm:317: (join-markups (cons (car remaining) (cons m
markups)) (cdr remaining))
indent

http://codereview.appspot.com/3992042/diff/1/scm/time-signature-settings.scm#...
scm/time-signature-settings.scm:320: ; Use a centered-column inside a
left-column, because the centered column
;;

http://codereview.appspot.com/3992042/diff/1/scm/time-signature-settings.scm#...
scm/time-signature-settings.scm:321: ; moves its reference point to the center,
which the left-column undoes.
;;

http://codereview.appspot.com/3992042/diff/1/scm/time-signature-settings.scm#...
scm/time-signature-settings.scm:334: (let* ((sigs (map format-time-fraction
time-sig)))
let

http://codereview.appspot.com/3992042/diff/1/scm/time-signature-settings.scm#...
scm/time-signature-settings.scm:357: (let* ((sigs (map calculate-time-fraction
time-sig)))
let

http://codereview.appspot.com/3992042/diff/1/scm/time-signature-settings.scm#...
scm/time-signature-settings.scm:361: (add-moment (ly:moment-add moment (car
remaining)) (cdr remaining))
indent

http://codereview.appspot.com/3992042/diff/1/scm/time-signature-settings.scm#...
scm/time-signature-settings.scm:379: ((not (pair? time-sig)) 4)
indent

http://codereview.appspot.com/3992042/diff/1/scm/time-signature-settings.scm#...
scm/time-signature-settings.scm:393: ; Normalize to given beat, extract the
beats and join them to one list
;;
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b