Issue 3989049: regression tests for white mensural ligature enhancements (Closed)
|
Created:
13 years, 3 months ago by benko.pal Modified:
13 years ago CC:
lilypond-devel_gnu.org Visibility:
Public. |
Descriptionenhance ligature test with new features
Patch Set 1 #Patch Set 2 : document new mensural features #
Total comments: 7
Patch Set 3 : some requested improvements #MessagesTotal messages: 11
and a try at Changes.
Sign in to reply to this message.
On 2011/01/29 14:07:20, benko.pal wrote: > and a try at Changes. LGTM; please send me a git-format origin patch and I'll push it.
Sign in to reply to this message.
> LGTM; please send me a git-format origin patch and I'll push it. thanks! p
Sign in to reply to this message.
Looks good enough to me -- it doesn't completely match our doc policies, but the whole Ancient music doesn't follow them either, and fixing that is a job for documentation writers, not programmers. Please send me a git format-patch origin for this. (also, please read the latest docs for git-cl in the CG, especially the "resetting git-cl" part)
Sign in to reply to this message.
Just some minor syntax changes to make it read better. I hope no one is offended. http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancien... File Documentation/notation/ancient.itely (left): http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancien... Documentation/notation/ancient.itely:500: General: There is an inconsistency using 'notehead' vs 'note head', so we need to pick one and stick with it. There is nothing in the CG (yet) and so we could make a policy if someone has a strong opinion on this. http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancien... File Documentation/notation/ancient.itely (right): http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancien... Documentation/notation/ancient.itely:682: The @code{blackpetrucci} style gives noteheads usable in black "The @code{blackpetrucci} style produces ..." http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancien... Documentation/notation/ancient.itely:687: can be different if coloratio is used e.g. to notate triplets). "Because note head style does not influence flag count, a semiminima should be notated as @code{a8*2} not @code{a4) otherwise it will look like a minima." Then start a new para with no parenthesis: "The multiplyer can be differerent..." http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancien... Documentation/notation/ancient.itely:813: using pitched rests. "Longa rests are not grouped automatically so have to be done manually by ...." http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancien... Documentation/notation/ancient.itely:942: property @code{flexa-width}. The length of a flexa can be set by the note head property @code{flexa-width}. http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancien... Documentation/notation/ancient.itely:966: \[ d\longa Can we put note durations for the first note of every new line (again as per the CG)? http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancien... Documentation/notation/ancient.itely:1014: Accidentals may collide with previous notes. Can we also suggest (if possible) any useful ways to avoid this or tell the user how they can workaround this - for instance using some 'hack' or spacing parameter - maybe even reference another section if it is useful. I just feel that stating this without a possible workaround is not as helpful as we could be, even if it is informative.
Sign in to reply to this message.
On Mon, Jan 31, 2011 at 11:17:46AM +0000, pkx166h@gmail.com wrote: > Just some minor syntax changes to make it read better. I hope no one is > offended. Not offended, but unfortunately I already pushed it. Could you make these changes to git? I don't want to slow down code development by asking non-English speakers to revise text a lot. As long as the doc team can understand it, I think it's best for programmers to be programming. > Documentation/notation/ancient.itely:500: > General: There is an inconsistency using 'notehead' vs 'note head', so > we need to pick one and stick with it. There is nothing in the CG (yet) > and so we could make a policy if someone has a strong opinion on this. gperciva@futoi:~/src/lilypond/Documentation/contributor$ grep notehead * doc-work.itexi:@emph{Note head} NOT notehead. that seems like a pretty clear policy. I didn't check this in the patch, though. Cheers, - Graham
Sign in to reply to this message.
sorry Graham; next time I'll try to remember to open a new issue after pushing. p
Sign in to reply to this message.
(I don't know what happened to my reply, trying again.) 2011/1/31 <pkx166h@gmail.com>: > Just some minor syntax changes to make it read better. I hope no one is > offended. on the contrary! > http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancien... > File Documentation/notation/ancient.itely (left): > > http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancien... > Documentation/notation/ancient.itely:500: > General: There is an inconsistency using 'notehead' vs 'note head', so > we need to pick one and stick with it. There is nothing in the CG (yet) > and so we could make a policy if someone has a strong opinion on this. done. > http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancien... > File Documentation/notation/ancient.itely (right): > > http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancien... > Documentation/notation/ancient.itely:682: The @code{blackpetrucci} style > gives noteheads usable in black > "The @code{blackpetrucci} style produces ..." done. > http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancien... > Documentation/notation/ancient.itely:687: can be different if coloratio > is used e.g. to notate triplets). > "Because note head style does not influence flag count, a semiminima > should be notated as @code{a8*2} not @code{a4) otherwise it will look > like a minima." > > Then start a new para with no parenthesis: > > "The multiplyer can be differerent..." modified, but not exactly this way. I wanted the multiplyer sentence refer to the blackpetrucci section, not to the semipetrucci one. > http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancien... > Documentation/notation/ancient.itely:813: using pitched rests. > "Longa rests are not grouped automatically so have to be done manually > by ...." done. > http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancien... > Documentation/notation/ancient.itely:942: property @code{flexa-width}. > The length of a flexa can be set by the note head property > @code{flexa-width}. done. > http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancien... > Documentation/notation/ancient.itely:966: \[ d\longa > Can we put note durations for the first note of every new line (again as > per the CG)? I'm afraid I don't get this. all first notes have duration, don't they? > http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancien... > Documentation/notation/ancient.itely:1014: Accidentals may collide with > previous notes. > Can we also suggest (if possible) any useful ways to avoid this or tell > the user how they can workaround this - for instance using some 'hack' > or spacing parameter - maybe even reference another section if it is > useful. I just feel that stating this without a possible workaround is > not as helpful as we could be, even if it is informative. I'm afraid (based on the horrible horizontal spacing around ligatures) that such a workaround is not possible. fortunately this situation is very rare. http://codereview.appspot.com/3989049/
Sign in to reply to this message.
On Tue, Feb 01, 2011 at 10:33:17PM +0100, Benkő Pál wrote: > 2011/1/31 <pkx166h@gmail.com>: > > http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancien... > > Documentation/notation/ancient.itely:966: \[ d\longa > > Can we put note durations for the first note of every new line (again as > > per the CG)? > > I'm afraid I don't get this. all first notes have duration, don't they? The first note on *every line*. Cheers, - Graham
Sign in to reply to this message.
Thanks, that all looks good.
Sign in to reply to this message.
>> > http://codereview.appspot.com/3989049/diff/3002/Documentation/notation/ancien... >> > Documentation/notation/ancient.itely:966: \[ d\longa >> > Can we put note durations for the first note of every new line (again as >> > per the CG)? >> >> I'm afraid I don't get this. all first notes have duration, don't they? > > The first note on *every line*. still confused, but a new idea struck me: the problem is not with that example, but with all other? I hope I'll have time to do that in two days. p
Sign in to reply to this message.
|
