Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1110)

Issue 3988045: code review 3988045: encoding/line: fix up a few typos and infelicities in t... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 11 months ago by r
Modified:
14 years, 10 months ago
Reviewers:
CC:
anschelsc_gmail.com, agl1, golang-dev
Visibility:
Public.

Description

encoding/line: fix up a few typos and infelicities in the doc comments

Patch Set 1 #

Patch Set 2 : code review 3988045: encoding/line: fix up a few typos and infelicities in t... #

Total comments: 2

Patch Set 3 : code review 3988045: encoding/line: fix up a few typos and infelicities in t... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/pkg/encoding/line/line.go View 1 2 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6
r
Hello agl, anschelsc@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 11 months ago (2011-01-22 22:53:57 UTC) #1
anschelsc
On 2011/01/22 22:53:57, r wrote: > Hello agl, https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=anschelsc@gmail.com (cc: https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=golang-dev@googlegroups.com), > > I'd like ...
14 years, 11 months ago (2011-01-23 04:48:53 UTC) #2
r
Hello agl, anschelsc@gmail.com, anschelsc (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 11 months ago (2011-01-23 07:35:38 UTC) #3
anschelsc
On 2011/01/23 07:35:38, r wrote: > Hello agl, https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=anschelsc@gmail.com, anschelsc (cc: https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=golang-dev@googlegroups.com), > > Please ...
14 years, 10 months ago (2011-01-23 13:37:38 UTC) #4
agl1
LGTM, thanks! http://codereview.appspot.com/3988045/diff/4001/src/pkg/encoding/line/line.go File src/pkg/encoding/line/line.go (right): http://codereview.appspot.com/3988045/diff/4001/src/pkg/encoding/line/line.go#newcode21 src/pkg/encoding/line/line.go:21: // NewReader returns a new reader that ...
14 years, 10 months ago (2011-01-24 15:07:58 UTC) #5
r
14 years, 10 months ago (2011-01-24 18:19:29 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=163450d02f33 ***

encoding/line: fix up a few typos and infelicities in the doc comments

R=anschelsc, agl1
CC=golang-dev
http://codereview.appspot.com/3988045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b