Issue 3985047: code review 3985047: gob: make nested interfaces work.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3985047: code review 3985047: gob: make nested interfaces work. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by r

Modified:
14 years, 4 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

gob: make nested interfaces work. Also clean up the code, make it more regular. Fixes issue 1416.

Patch Set 2 : code review 3985047: gob: make nested interfaces work. #

Patch Set 3 : code review 3985047: gob: make nested interfaces work. #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+241 lines, -143 lines)			Patch
M	src/pkg/gob/codec_test.go	View		5 chunks	+4 lines, -5 lines	0 comments	Download
M	src/pkg/gob/decode.go	View		11 chunks	+35 lines, -19 lines	0 comments	Download
M	src/pkg/gob/decoder.go	View		4 chunks	+104 lines, -83 lines	0 comments	Download
M	src/pkg/gob/encode.go	View		1 chunk	+10 lines, -6 lines	0 comments	Download
M	src/pkg/gob/encoder.go	View	1 2	9 chunks	+44 lines, -30 lines	0 comments	Download
M	src/pkg/gob/encoder_test.go	View	1	1 chunk	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 4 months ago (2011-01-26 02:55:17 UTC) #1

rsc

LGTM http://codereview.appspot.com/3985047/diff/1/src/pkg/gob/encoder.go File src/pkg/gob/encoder.go (right): http://codereview.appspot.com/3985047/diff/1/src/pkg/gob/encoder.go#newcode21 src/pkg/gob/encoder.go:21: // state *encoderState // so we can encode ...

14 years, 4 months ago (2011-01-28 18:07:37 UTC) #2

14 years, 4 months ago (2011-01-28 18:53:45 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=e8a657d4792b ***

gob: make nested interfaces work.
Also clean up the code, make it more regular.

Fixes issue 1416.

R=rsc
CC=golang-dev
http://codereview.appspot.com/3985047

Expand All Messages | Collapse All Messages