Issue 3984042: code review 3984042: godoc: enable qualified identifiers ("math.Sin") as que...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3984042: code review 3984042: godoc: enable qualified identifiers ("math.Sin") as que... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by gri

Modified:
14 years, 5 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

godoc: enable qualified identifiers ("math.Sin") as query strings again A query string of the form ident.ident will be used both as a qualified identifier for identifier search and as a regular expression. Qualified identifier lookup got broken accidentally when introducing regexp full text search. Cleaned up surrounding logic a bit.

Patch Set 1 #

Patch Set 2 : code review 3984042: godoc: enable qualified identifiers ("math.Sin") as que... #

Patch Set 3 : code review 3984042: godoc: enable qualified identifiers ("math.Sin") as que... #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -22 lines)			Patch
	M	src/cmd/godoc/godoc.go	View	1	1 chunk	+19 lines, -22 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 5 months ago (2011-01-19 19:22:04 UTC) #1

gri

14 years, 5 months ago (2011-01-19 20:48:12 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=8483bcc4c629 ***

godoc: enable qualified identifiers ("math.Sin") as query strings again

A query string of the form ident.ident will be used both as a qualified
identifier for identifier search and as a regular expression.
Qualified identifier lookup got broken accidentally when introducing
regexp full text search. Cleaned up surrounding logic a bit.

R=rsc
CC=golang-dev
http://codereview.appspot.com/3984042

Expand All Messages | Collapse All Messages