Issue 3979045: code review 3979045: doc/codelab/wiki: update to work with template changes,...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3979045: code review 3979045: doc/codelab/wiki: update to work with template changes,... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by adg

Modified:
14 years, 3 months ago

Reviewers:

CC:
rsc, r, golang-dev

Visibility:
Public.

Description

doc/codelab/wiki: update to work with template changes, add to run.bash Fixes issue 1444.

Patch Set 2 : code review 3979045: doc/codelab/wiki: update to work with template changes,... #

Total comments: 1

Patch Set 3 : code review 3979045: doc/codelab/wiki: update to work with template changes,... #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -190 lines)			Patch
M	doc/codelab/wiki/edit.html	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	doc/codelab/wiki/final.go	View		3 chunks	+11 lines, -11 lines	0 comments	Download
M	doc/codelab/wiki/final-noclosure.go	View		4 chunks	+11 lines, -11 lines	0 comments	Download
M	doc/codelab/wiki/final-noerror.go	View		2 chunks	+9 lines, -9 lines	0 comments	Download
M	doc/codelab/wiki/final-parsetemplate.go	View		3 chunks	+11 lines, -11 lines	0 comments	Download
M	doc/codelab/wiki/final-template.go	View		3 chunks	+11 lines, -11 lines	0 comments	Download
M	doc/codelab/wiki/htmlify.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	doc/codelab/wiki/index.html	View	1	29 chunks	+58 lines, -59 lines	0 comments	Download
M	doc/codelab/wiki/notemplate.go	View		2 chunks	+11 lines, -11 lines	0 comments	Download
M	doc/codelab/wiki/part1.go	View		1 chunk	+10 lines, -10 lines	0 comments	Download
M	doc/codelab/wiki/part1-noerror.go	View		1 chunk	+10 lines, -10 lines	0 comments	Download
M	doc/codelab/wiki/part2.go	View		2 chunks	+9 lines, -9 lines	0 comments	Download
M	doc/codelab/wiki/srcextract.go	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	doc/codelab/wiki/test_edit.good	View		1 chunk	+1 line, -1 line	0 comments	Download
M	doc/codelab/wiki/view.html	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	doc/codelab/wiki/wiki.html	View		17 chunks	+28 lines, -28 lines	0 comments	Download
M	src/run.bash	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2011-01-26 03:01:41 UTC) #1

LGTM http://codereview.appspot.com/3979045/diff/3001/doc/codelab/wiki/final-noclosure.go File doc/codelab/wiki/final-noclosure.go (right): http://codereview.appspot.com/3979045/diff/3001/doc/codelab/wiki/final-noclosure.go#newcode11 doc/codelab/wiki/final-noclosure.go:11: type Page struct { the type doesn't have ...

14 years, 3 months ago (2011-01-26 03:48:17 UTC) #2

adg

*** Submitted as http://code.google.com/p/go/source/detail?r=235d53c7b1d8 *** doc/codelab/wiki: update to work with template changes, add to run.bash ...

14 years, 3 months ago (2011-01-26 04:57:06 UTC) #3

adg

14 years, 3 months ago (2011-01-26 04:57:34 UTC) #4

On 26 January 2011 13:48,  <r@golang.org> wrote:
> LGTM
>
>
>
http://codereview.appspot.com/3979045/diff/3001/doc/codelab/wiki/final-noclos...
> File doc/codelab/wiki/final-noclosure.go (right):
>
>
http://codereview.appspot.com/3979045/diff/3001/doc/codelab/wiki/final-noclos...
> doc/codelab/wiki/final-noclosure.go:11: type Page struct {
> the type doesn't have to be exported, but it's fine to do so

I decided to export it as there's no reason not to.

Expand All Messages | Collapse All Messages