Issue 3971044: code review 3971044: runtime: drop CLONE_PARENT

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3971044: code review 3971044: runtime: drop CLONE_PARENT (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by rsc

Modified:
14 years, 5 months ago

Reviewers:

CC:
adg, iant, golang-dev

Visibility:
Public.

Description

runtime: drop CLONE_PARENT The functionality we want (shared ppid) is implied by CLONE_THREAD already, and CLONE_PARENT causes problems if the Go program is pid 1 (init). See issue 1406 for more details. Fixes issue 1406.

Patch Set 1 #

Patch Set 2 : code review 3971044: runtime: drop CLONE_PARENT #

Patch Set 3 : code review 3971044: runtime: drop CLONE_PARENT #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	src/pkg/runtime/linux/thread.c	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 5 months ago (2011-01-20 18:10:46 UTC) #1

rsc

14 years, 5 months ago (2011-01-20 18:36:04 UTC) #3

*** Submitted as d156277812c2 ***

runtime: drop CLONE_PARENT

The functionality we want (shared ppid) is implied
by CLONE_THREAD already, and CLONE_PARENT
causes problems if the Go program is pid 1 (init).

See issue 1406 for more details.

Fixes issue 1406.

R=adg, iant
CC=golang-dev
http://codereview.appspot.com/3971044

Expand All Messages | Collapse All Messages