Issue 3970045: code review 3970045: gob: better debugging, commentary

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3970045: code review 3970045: gob: better debugging, commentary (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by r

Modified:
14 years, 5 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

gob: better debugging, commentary Re-implement the debugging helper to be independent of the existing implementation. This is preparatory to a rewrite to clean up issue 1416. Include a definition of the grammar of the data stream.

Patch Set 1 #

Patch Set 2 : code review 3970045: gob: better debugging, commentary #

Total comments: 2

Patch Set 3 : code review 3970045: gob: better debugging, commentary #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+687 lines, -233 lines)			Patch
M	src/pkg/gob/codec_test.go	View		2 chunks	+26 lines, -1 line	0 comments	Download
M	src/pkg/gob/debug.go	View	1 2	1 chunk	+594 lines, -220 lines	0 comments	Download
M	src/pkg/gob/decode.go	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	src/pkg/gob/decoder.go	View		4 chunks	+14 lines, -9 lines	0 comments	Download
M	src/pkg/gob/doc.go	View		1 chunk	+48 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 5 months ago (2011-01-20 23:38:04 UTC) #1

rsc

LGTM http://codereview.appspot.com/3970045/diff/2001/src/pkg/gob/debug.go File src/pkg/gob/debug.go (right): http://codereview.appspot.com/3970045/diff/2001/src/pkg/gob/debug.go#newcode13 src/pkg/gob/debug.go:13: "sync" sort http://codereview.appspot.com/3970045/diff/2001/src/pkg/gob/debug.go#newcode171 src/pkg/gob/debug.go:171: // readUint returns the ...

14 years, 5 months ago (2011-01-21 19:22:37 UTC) #2

14 years, 5 months ago (2011-01-21 19:29:00 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=226b2f21ef36 ***

gob: better debugging, commentary

Re-implement the debugging helper to be independent of the existing
implementation.  This is preparatory to a rewrite to clean up issue 1416.
Include a definition of the grammar of the data stream.

R=rsc
CC=golang-dev
http://codereview.appspot.com/3970045

Expand All Messages | Collapse All Messages