Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(511)

Issue 3926044: code review 3926044: go spec: adjust notion of Assignability (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 3 months ago by gri
Modified:
14 years, 3 months ago
Reviewers:
CC:
r, rsc, iant, ken2, golang-dev
Visibility:
Public.

Description

go spec: adjust notion of Assignability This change makes it legal to pass a struct value as receiver outside the package declaring the struct even if the respective struct type has non-exported fields. This is a backwards-compatible language change motivated by the fact that it is already possible to circumvent the assignment restriction when calling methods through interfaces (see issue 1402).

Patch Set 1 #

Patch Set 2 : code review 3926044: go spec: adjust notion of Assignability #

Patch Set 3 : code review 3926044: go spec: adjust notion of Assignability #

Patch Set 4 : code review 3926044: go spec: adjust notion of Assignability #

Patch Set 5 : code review 3926044: go spec: adjust notion of Assignability #

Patch Set 6 : code review 3926044: go spec: adjust notion of Assignability #

Patch Set 7 : diff -r 53791c69fc6f https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r 53791c69fc6f https://go.googlecode.com/hg/ #

Patch Set 9 : diff -r e0e30925d60d https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M doc/go_spec.html View 1 2 3 4 7 8 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 3
gri
Hello r, rsc, iant, ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to ...
14 years, 3 months ago (2011-02-02 23:48:08 UTC) #1
rsc
LGTM
14 years, 3 months ago (2011-02-03 18:40:31 UTC) #2
gri
14 years, 3 months ago (2011-02-03 18:53:33 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=df410d6a4842 ***

go spec: adjust notion of Assignability

This change makes it legal to pass a struct value as receiver
outside the package declaring the struct even if the respective
struct type has non-exported fields.

This is a backwards-compatible language change motivated by the
fact that it is already possible to circumvent the assignment
restriction when calling methods through interfaces (see issue
1402).

R=r, rsc, iant, ken2
CC=golang-dev
http://codereview.appspot.com/3926044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b