Issue 3898042: code review 3898042: runtime: Restore scheduler stack position if cgo callba...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3898042: code review 3898042: runtime: Restore scheduler stack position if cgo callba... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by iant

Modified:
14 years, 5 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

runtime: Restore scheduler stack position if cgo callback panics. If we don't do this, then when C code calls back to Go code which panics, we lose space on the scheduler stack. If that happens a lot, eventually there is no space left on the scheduler stack.

Patch Set 1 #

Patch Set 2 : code review 3898042: runtime: Restore scheduler stack position if cgo callba... #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -0 lines)			Patch
	M	src/pkg/runtime/proc.c	View		1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 5 months ago (2011-01-08 00:38:05 UTC) #1

iant

14 years, 5 months ago (2011-01-08 18:22:44 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=02ef954111c6 ***

runtime: Restore scheduler stack position if cgo callback panics.

If we don't do this, then when C code calls back to Go code
which panics, we lose space on the scheduler stack.  If that
happens a lot, eventually there is no space left on the
scheduler stack.

R=rsc
CC=golang-dev
http://codereview.appspot.com/3898042

Expand All Messages | Collapse All Messages