code review 3896042: time.NewTicker: panic for intervals <= 0.

time.NewTicker: panic for intervals <= 0.
Not absolutely certain it's right to do this, but since there's
no error value coming back, it seems reasonable.

Fixes issue 1392.

[r, 2011-01-07 22:12:46]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[adg, 2011-01-07 22:33:29]

LGTM

On 8 January 2011 09:12,  <r@golang.org> wrote:
> Reviewers: rsc,
>
> Message:
> Hello rsc (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> time.NewTicker: panic for intervals <= 0.
> Not absolutely certain it's right to do this, but since there's
> no error value coming back, it seems reasonable.
>
> Fixes issue 1392.
>
> Please review this at http://codereview.appspot.com/3896042/
>
> Affected files:
>  M src/pkg/time/tick.go
>
>
> Index: src/pkg/time/tick.go
> ===================================================================
> --- a/src/pkg/time/tick.go
> +++ b/src/pkg/time/tick.go
> @@ -5,6 +5,7 @@
>  package time
>
>  import (
> +       "os"
>        "sync"
>  )
>
> @@ -163,10 +164,11 @@
>
>  // NewTicker returns a new Ticker containing a channel that will
>  // send the time, in nanoseconds, every ns nanoseconds.  It adjusts the
> -// intervals to make up for pauses in delivery of the ticks.
> +// intervals to make up for pauses in delivery of the ticks. The value of
> +// ns must be greater than zero; if not, NewTicker will panic.
>  func NewTicker(ns int64) *Ticker {
>        if ns <= 0 {
> -               return nil
> +               panic(os.ErrorString("non-positive interval for NewTicker"))
>        }
>        c := make(chan int64, 1) //  See comment on send in tickerLoop
>        t := &Ticker{
>
>
>

[r, 2011-01-07 22:41:48]

*** Submitted as http://code.google.com/p/go/source/detail?r=3aaeaeaaaff1 ***

time.NewTicker: panic for intervals <= 0.
Not absolutely certain it's right to do this, but since there's
no error value coming back, it seems reasonable.

Fixes issue 1392.

R=rsc, adg
CC=golang-dev
http://codereview.appspot.com/3896042