Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2071)

Issue 3858041: Fix 1464 (segfault with R1 and metronome) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by Graham Percival (old account)
Modified:
13 years, 3 months ago
Reviewers:
Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix 1464 (segfault with R1 and metronome) This code came from Mathias Kilian.

Patch Set 1 #

Patch Set 2 : Fix spelling of "Matthias". #

Total comments: 3

Patch Set 3 : fix regtest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
A input/regression/metronome-multimeasure-rest-no-segfault.ly View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
M lily/metronome-engraver.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5
Graham Percival (old account)
Fixes a segfault, passes the regtest comparison, code by Matthias Kilian.
13 years, 4 months ago (2011-01-02 00:50:13 UTC) #1
Neil Puttock
LGTM, but I'd rather we didn't set the parent twice (at least in the default ...
13 years, 4 months ago (2011-01-02 17:39:42 UTC) #2
Graham Percival (old account)
I've fixed the problems Neil identified in the regtest, but it's still setting the parent ...
13 years, 4 months ago (2011-01-03 02:55:37 UTC) #3
Graham Percival (old account)
Any other comments about this? I'm aware of some discussion here about get_parent: http://lists.gnu.org/archive/html/lilypond-devel/2011-01/msg00057.html http://lists.gnu.org/archive/html/lilypond-devel/2011-01/msg00055.html ...
13 years, 3 months ago (2011-01-07 08:52:02 UTC) #4
Graham Percival (old account)
13 years, 3 months ago (2011-01-08 06:49:55 UTC) #5
I've done two regtest checks, and it all seems fine, so I've pushed it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b