Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1818)

Issue 3827044: [PATCH] Remove unused variables found by gcc-4.6's -Wunused-but-set-variable (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by Jeffrey Yasskin
Modified:
13 years, 3 months ago
Reviewers:
kalle.raiskila, echristo
CC:
llvm-commits_cs.uiuc.edu
Base URL:
https://llvm.org/svn/llvm-project/llvm/trunk/
Visibility:
Public.

Description

Some of these removals may actually indicate bugs, so someone who knows this code better than I do should take a look. There are a couple other gcc-4.6 warnings in googletest, but we should get a fix for them when they release version 1.6.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -21 lines) Patch
M lib/Target/ARM/ARMFastISel.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M lib/Target/ARM/ARMFrameInfo.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M lib/Target/CellSPU/SPUISelLowering.cpp View 3 chunks +0 lines, -9 lines 0 comments Download
M lib/Target/PowerPC/PPCISelLowering.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M lib/Target/X86/X86ISelDAGToDAG.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3
Jeffrey Yasskin
13 years, 4 months ago (2011-01-07 00:31:40 UTC) #1
echristo_apple.com
> > Affected files: > M lib/Target/ARM/ARMFastISel.cpp > M lib/Target/ARM/ARMFrameInfo.cpp These changes are fine. Thanks! ...
13 years, 4 months ago (2011-01-07 00:37:28 UTC) #2
kalle.raiskila_nokia.com
13 years, 4 months ago (2011-01-07 09:39:31 UTC) #3
ext jyasskin@gmail.com skrev:
> Reviewers: ,
> 
> Description:
> Some of these removals may actually indicate bugs, so someone who knows
> this code better than I do should take a look.
> 
> There are a couple other gcc-4.6 warnings in googletest, but we should
> get a fix for them when they release version 1.6.
> 
> Please review this at http://codereview.appspot.com/3827044/
> 
> Affected files:
>    M     lib/Target/ARM/ARMFastISel.cpp
>    M     lib/Target/ARM/ARMFrameInfo.cpp
>    M     lib/Target/CellSPU/SPUISelLowering.cpp

Those unused in the CellSPU target are OK to remove.
(sorry, don't have an account to appspot)

thanks,
kalle


Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b