Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(35)

Issue 3760048: Update upload.py patch, add docs and example config files for running production server (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 5 months ago by techtonik
Modified:
13 years, 6 months ago
Reviewers:
Andi Albrecht, imirkin, Ilia Mirkin, gduponly
CC:
gae2django_googlegroups.com
Base URL:
http://django-gae2django.googlecode.com/svn/trunk/examples/rietveld/
Visibility:
Public.

Description

Patch for Rietveld example running standalone with gae2django

Patch Set 1 #

Total comments: 6

Patch Set 2 : English, add info on adding users, add mapping for admin resources into Apache example #

Patch Set 3 : .wsgi: prepend current dir to sys.path to override system version #

Total comments: 4

Patch Set 4 : Andi review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -8 lines) Patch
M README View 1 2 3 2 chunks +35 lines, -5 lines 0 comments Download
A apache.conf.example View 1 1 chunk +19 lines, -0 lines 0 comments Download
A codereview.wsgi.example View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M patches/upload.diff View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10
Ilia Mirkin
Just a few minor English corrections. Otherwise seems fine. I'll leave it up to Andi ...
15 years, 5 months ago (2011-01-12 18:54:05 UTC) #1
techtonik
Uploaded new patch set, this time it also includes information about adding users. http://codereview.appspot.com/3760048/diff/1/README File ...
15 years, 5 months ago (2011-01-12 19:15:59 UTC) #2
imirkin_alum.mit.edu
On Wed, Jan 12, 2011 at 2:16 PM, <techtonik@gmail.com> wrote: > Reviewers: Andi Albrecht, Ilia ...
15 years, 5 months ago (2011-01-12 19:29:18 UTC) #3
techtonik
15 years, 5 months ago (2011-01-12 21:22:09 UTC) #4
techtonik
Andi, do you have time for review this week?
15 years, 4 months ago (2011-01-17 15:22:48 UTC) #5
Andi Albrecht
[hehe, this review is on my todo list for today... :-)] I've already had a ...
15 years, 4 months ago (2011-01-17 19:44:00 UTC) #6
techtonik
Done. http://codereview.appspot.com/3760048/diff/17001/README File README (right): http://codereview.appspot.com/3760048/diff/17001/README#newcode83 README:83: The preferred method to deploy Django applications is ...
15 years, 4 months ago (2011-01-18 21:09:00 UTC) #7
Andi Albrecht
Committed r157. Thanks, Anatoly! (I hope that the wording if ok now, otherwise Google Code ...
15 years, 4 months ago (2011-01-20 09:25:38 UTC) #8
techtonik
Wow! That's extremely useful. If they continue to do these things, I'll have nothing to ...
15 years, 4 months ago (2011-01-20 21:50:53 UTC) #9
gDuponly
13 years, 6 months ago (2012-12-07 00:25:23 UTC) #10

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b