Issue 3749044: code review 3749044: fmt: normalize processing of format string

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3749044: code review 3749044: fmt: normalize processing of format string (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by r

Modified:
14 years, 5 months ago

Reviewers:

CC:
rsc, Kyle C, golang-dev

Visibility:
Public.

Description

fmt: normalize processing of format string The old loop was a bit odd; change it to be more regular. This also enables a diagnostic for Printf("%", 3): %!(NOVERB)

Patch Set 1 #

Patch Set 2 : code review 3749044: fmt: normalize processing of format string #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -12 lines)			Patch
	M	src/pkg/fmt/fmt_test.go	View		3 chunks	+5 lines, -3 lines	0 comments	Download
	M	src/pkg/fmt/print.go	View		4 chunks	+11 lines, -9 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com, consalus@gmail.com), I'd like you to review this change.

14 years, 5 months ago (2011-01-05 18:06:29 UTC) #1

14 years, 5 months ago (2011-01-05 18:11:36 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=f9ed0be64ece ***

fmt: normalize processing of format string
The old loop was a bit odd; change it to be more regular.
This also enables a diagnostic for Printf("%", 3): %!(NOVERB)

R=rsc, Kyle C
CC=golang-dev
http://codereview.appspot.com/3749044

Expand All Messages | Collapse All Messages