Issue 3680041: crypto/tls: check in support code.

Issue 3680041: crypto/tls: check in support code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by agl1

Modified:
14 years, 6 months ago

Reviewers:

CC:
rsc, ality, golang-dev

Visibility:
Public.

Description

crypto/tls: check in support code. This support code helps in generating the handshake scripts which are used for testing.

Patch Set 2 : code review 3680041: crypto/tls: check in support code. #

Total comments: 2

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -4 lines)			Patch
M	src/pkg/crypto/tls/handshake_server_test.go	View		1 chunk	+4 lines, -4 lines	1 comment	Download
A	src/pkg/crypto/tls/parse-gnutls-cli-debug-log.py	View		1 chunk	+55 lines, -0 lines	1 comment	Download
A	src/pkg/crypto/tls/test_server.go	View	1	1 chunk	+81 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rsc1

LGTM http://codereview.appspot.com/3680041/diff/2001/src/pkg/crypto/tls/parse-gnutls-cli-debug-log.py File src/pkg/crypto/tls/parse-gnutls-cli-debug-log.py (right): http://codereview.appspot.com/3680041/diff/2001/src/pkg/crypto/tls/parse-gnutls-cli-debug-log.py#newcode6 src/pkg/crypto/tls/parse-gnutls-cli-debug-log.py:6: # script of the handshake. This script is ...

14 years, 6 months ago (2010-12-15 18:18:53 UTC) #2

ality

http://codereview.appspot.com/3680041/diff/2001/src/pkg/crypto/tls/handshake_server_test.go File src/pkg/crypto/tls/handshake_server_test.go (right): http://codereview.appspot.com/3680041/diff/2001/src/pkg/crypto/tls/handshake_server_test.go#newcode192 src/pkg/crypto/tls/handshake_server_test.go:192: // The values for this test are obtained by ...

14 years, 6 months ago (2010-12-15 20:06:20 UTC) #3

agl1

On Wed, Dec 15, 2010 at 3:06 PM, <ality@pbrane.org> wrote: > http://codereview.appspot.com/3680041/diff/2001/src/pkg/crypto/tls/handshake_server_test.go#newcode192 > src/pkg/crypto/tls/handshake_server_test.go:192: // ...

14 years, 6 months ago (2010-12-15 20:15:31 UTC) #4

agl1

*** Submitted as http://code.google.com/p/go/source/detail?r=b7b92d1bdcf4 *** crypto/tls: check in support code. This support code helps in ...

14 years, 6 months ago (2010-12-16 15:40:14 UTC) #5

agl1

14 years, 6 months ago (2010-12-16 15:40:38 UTC) #6

On Wed, Dec 15, 2010 at 3:15 PM, Adam Langley <agl@golang.org> wrote:
> I'll remove test_server.go from the CL before submitting.

Submitted.

Expand All Messages | Collapse All Messages