Issue 3621041: code review 3621041: gc: complex(0)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3621041: code review 3621041: gc: complex(0) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by rsc

Modified:
14 years, 4 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

gc: complex(0) Fixes issue 1232.

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -5 lines)			Patch
M	src/cmd/gc/const.c	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	src/cmd/gc/mparith1.c	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/cmplx.go	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 4 months ago (2010-12-13 20:34:44 UTC) #1

rsc

*** Submitted as 9ec88545a083 *** gc: complex(0) Fixes issue 1232. R=ken2 CC=golang-dev http://codereview.appspot.com/3621041

14 years, 4 months ago (2010-12-13 20:34:47 UTC) #2

lgtm