code review 3606043: A selection of trivials.

A selection of trivials.

[niemeyer, 2010-12-12 22:05:46]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[gri, 2010-12-12 22:16:02]

LGTM
thanks
- gri

On Sun, Dec 12, 2010 at 2:05 PM, <n13m3y3r@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> A selection of trivials.
>
> Please review this at http://codereview.appspot.com/3606043/
>
> Affected files:
>  M lib/godoc/package.html
>  M src/cmd/gc/align.c
>  M src/pkg/go/doc/doc.go
>
>
> Index: lib/godoc/package.html
> ===================================================================
> --- a/lib/godoc/package.html
> +++ b/lib/godoc/package.html
> @@ -104,12 +104,12 @@
>        <th align="left">Synopsis</th>
>        </tr>
>        <tr>
> -       <th align="left"><a href="..">..<a></th>
> +       <th align="left"><a href="..">..</a></th>
>        </tr>
>        {.repeated section List}
>                <tr>
>                {Depth|padding}
> -               <td align="left" colspan="{Height|html-esc}"><a
> href="{Path|html-esc}">{Name|html-esc}<a></td>
> +               <td align="left" colspan="{Height|html-esc}"><a
> href="{Path|html-esc}">{Name|html-esc}</a></td>
>                <td></td>
>                <td align="left">{Synopsis|html-esc}</td>
>                </tr>
> Index: src/cmd/gc/align.c
> ===================================================================
> --- a/src/cmd/gc/align.c
> +++ b/src/cmd/gc/align.c
> @@ -7,8 +7,8 @@
>  /*
>  * machine size and rounding
>  * alignment is dictated around
> - * the size of a pointer, set in belexinit
> - * (see ../6g/align.c).
> + * the size of a pointer, set in betypeinit
> + * (see ../6g/galign.c).
>  */
>
>  static int defercalc;
> Index: src/pkg/go/doc/doc.go
> ===================================================================
> --- a/src/pkg/go/doc/doc.go
> +++ b/src/pkg/go/doc/doc.go
> @@ -127,7 +127,7 @@
>                        name := ""
>                        switch {
>                        case v.Type != nil:
> -                               // a type is present; determine it's name
> +                               // a type is present; determine its name
>                                name = baseTypeName(v.Type)
>                        case decl.Tok == token.CONST:
>                                // no type is present but we have a constant
> declaration;
>
>
>

[gri, 2010-12-12 22:16:41]

*** Submitted as http://code.google.com/p/go/source/detail?r=4861544653a5 ***

A selection of trivials.

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/3606043

Committer: Robert Griesemer <gri@golang.org>