harmonics and slides

harmonics and slides



NR-harmonics-and-slides

fretted-strings.itely: Documentation of new harmonic functions (\harmonicByFret and \harmonicByRatio).
New snippet for slides (glissandi). Added warning that \hideNotes/\unHideNotes cannot be used in tablatures.

[Graham Percival (old account), 2010-12-11 16:16:02]

Looks basically good.

http://codereview.appspot.com/3590041/diff/1/Documentation/notation/fretted-s...
File Documentation/notation/fretted-strings.itely (right):

http://codereview.appspot.com/3590041/diff/1/Documentation/notation/fretted-s...
Documentation/notation/fretted-strings.itely:383: @noindent
Please remove all the @noindents.

http://codereview.appspot.com/3590041/diff/1/Documentation/notation/fretted-s...
Documentation/notation/fretted-strings.itely:407: Alternatively harmonics can be
computed by defining the ratio of
Comma should be after the "Alternatively"

[Carl, 2010-12-11 16:34:00]

Looks pretty good to me.  Looks *excellent* for a first patch.

Thanks,

Carl

http://codereview.appspot.com/3590041/diff/1/Documentation/notation/fretted-s...
File Documentation/notation/fretted-strings.itely (right):

http://codereview.appspot.com/3590041/diff/1/Documentation/notation/fretted-s...
Documentation/notation/fretted-strings.itely:408: dividing a string into equal
lengths.
ratio of string lengths above and below the harmonic fingering

http://codereview.appspot.com/3590041/diff/1/Documentation/notation/fretted-s...
Documentation/notation/fretted-strings.itely:427: Slides can be typeset by
attaching @code{\glissando} to a note:
Generally we don't like to indicate the syntax used to achieve an effect in the
body of the documentation, because it won't be automatically updated in the
event the syntax changes.

I'd recommend that this sentence be changed to:

Slides can by typeset in both @code{Staff} and @code{TabStaff} contexts:

http://codereview.appspot.com/3590041/diff/1/Documentation/notation/fretted-s...
Documentation/notation/fretted-strings.itely:491: @noindent
Do we want to have\hideNotes apply to TabVoice?  If so, we could change the
definition of \hideNotes.  That would probably be better than a known issue.

[pls, 2010-12-11 16:54:29]

Am 11.12.2010 um 17:34 schrieb Carl.D.Sorensen@gmail.com:

> Looks pretty good to me.  Looks *excellent* for a first patch.
>
> Thanks,
>
> Carl
>
>
>
> http://codereview.appspot.com/3590041/diff/1/Documentation/notation/ 
> fretted-strings.itely
> File Documentation/notation/fretted-strings.itely (right):
>
> http://codereview.appspot.com/3590041/diff/1/Documentation/notation/ 
> fretted-strings.itely#newcode408
> Documentation/notation/fretted-strings.itely:408: dividing a string  
> into
> equal lengths.
> ratio of string lengths above and below the harmonic fingering
>
> http://codereview.appspot.com/3590041/diff/1/Documentation/notation/ 
> fretted-strings.itely#newcode427
> Documentation/notation/fretted-strings.itely:427: Slides can be  
> typeset
> by attaching @code{\glissando} to a note:
> Generally we don't like to indicate the syntax used to achieve an  
> effect
> in the body of the documentation, because it won't be automatically
> updated in the event the syntax changes.
>
> I'd recommend that this sentence be changed to:
>
> Slides can by typeset in both @code{Staff} and @code{TabStaff}  
> contexts:
>
> http://codereview.appspot.com/3590041/diff/1/Documentation/notation/ 
> fretted-strings.itely#newcode491
> Documentation/notation/fretted-strings.itely:491: @noindent
> Do we want to have\hideNotes apply to TabVoice?  If so, we could  
> change
> the definition of \hideNotes.  That would probably be better than a
> known issue.
IMHO I think we want to have \hideNotes apply to TabVoice. I tried to  
achieve glissandi with an indefinite beginning/ending (but in vain):

slides = {
   c'8\3\glissando( d'8\3)
   c'8\3\glissando d'8\3
   \hideNotes
   \grace { \stemDown a16\3\glissando }
   \unHideNotes
   c'4\3
   \afterGrace d'4\3\glissando {
   \stemDown  \hideNotes
   g16\3 }
}

\score {
	<<
	\new Staff { \clef "treble_8" \slides }
	\new TabStaff {
           \new TabVoice {
		\tabFullNotation
		\slides }}
	>>
}
>
> http://codereview.appspot.com/3590041/

[c_sorensen, 2010-12-11 17:03:53]

On 12/11/10 9:54 AM, "Patrick Schmidt" <p.l.schmidt@gmx.de> wrote:

> 
> 
> Am 11.12.2010 um 17:34 schrieb Carl.D.Sorensen@gmail.com:
> 

>> Do we want to have\hideNotes apply to TabVoice?  If so, we could
>> change
>> the definition of \hideNotes.  That would probably be better than a
>> known issue.
> IMHO I think we want to have \hideNotes apply to TabVoice. I tried to
> achieve glissandi with an indefinite beginning/ending (but in vain):

You can test this really easily.


Simply add

\override TabNoteHead #'transparent = ##t

after line 233 of ly/property-init.ly, and

\revert TabNoteHead #'transparent

after line 243 of ly/property-init.ly

You could do so, and make it part of this patch.

Thanks,

Carl

[pls, 2010-12-11 19:44:21]

Am 11.12.2010 um 18:03 schrieb Carl Sorensen:

> On 12/11/10 9:54 AM, "Patrick Schmidt" <p.l.schmidt@gmx.de> wrote:
>
>> IMHO I think we want to have \hideNotes apply to TabVoice. I tried to
>> achieve glissandi with an indefinite beginning/ending (but in vain):
>
> You can test this really easily.
>
>
> Simply add
>
> \override TabNoteHead #'transparent = ##t
>
> after line 233 of ly/property-init.ly, and
>
> \revert TabNoteHead #'transparent
>
> after line 243 of ly/property-init.ly
>
> You could do so, and make it part of this patch.
>
> Thanks,
>
> Carl

Wow, that was easy! Unfortunately some overrides are necessary in  
order to make the glissandi look half decent. The problem is that it  
seems to be impossible to find an optimal setting for both staffs and  
tab staffs. Without the overrides the slides are not visible in  
normal staffs (not even with a 400 % zoom-in). With these overrides  
glissandi are longer in TabStaffs than in Staffs. And because of  
these overrides this snippet would have to go in selected snippets  
rather than the body of the chapter?!

slides = {
   \override Glissando #'minimum-length = #4
   \override Glissando #'springs-and-rods = #ly:spanner::set-spacing- 
rods
   \override Glissando #'thickness = #2
   c'8\3\glissando( d'8\3)
   c'8\3\glissando d'8\3
   \hideNotes
   \grace { \stemDown g16\3\glissando } \unHideNotes
   c'4\3
   \afterGrace d'4\3\glissando { \stemDown  \hideNotes
   g16\3 }
}

\score {
	<<
	\new Staff { \clef "treble_8" \slides }
	\new TabStaff {
           \new TabVoice {
		\tabFullNotation
		\slides
           }
        }
	>>
}

Thanks,

patrick

[c_sorensen, 2010-12-11 19:55:50]

On 12/11/10 12:44 PM, "Patrick Schmidt" <p.l.schmidt@gmx.de> wrote:

> 
> 
> Am 11.12.2010 um 18:03 schrieb Carl Sorensen:
> 
>> On 12/11/10 9:54 AM, "Patrick Schmidt" <p.l.schmidt@gmx.de> wrote:
>> 
>>> IMHO I think we want to have \hideNotes apply to TabVoice. I tried to
>>> achieve glissandi with an indefinite beginning/ending (but in vain):
>> 
>> You can test this really easily.
>> 
>> 
>> Simply add
>> 
>> \override TabNoteHead #'transparent = ##t
>> 
>> after line 233 of ly/property-init.ly, and
>> 
>> \revert TabNoteHead #'transparent
>> 
>> after line 243 of ly/property-init.ly
>> 
>> You could do so, and make it part of this patch.
>> 
>> Thanks,
>> 
>> Carl
> 
> Wow, that was easy! Unfortunately some overrides are necessary in
> order to make the glissandi look half decent. The problem is that it
> seems to be impossible to find an optimal setting for both staffs and
> tab staffs. Without the overrides the slides are not visible in
> normal staffs (not even with a 400 % zoom-in). With these overrides
> glissandi are longer in TabStaffs than in Staffs. And because of
> these overrides this snippet would have to go in selected snippets
> rather than the body of the chapter?!

So perhaps what you do is put this (along with the \chordGlissando) function
in a file ly/string-instruments.ly.

And you define a music function \slide (perhaps including the call to
\glissando; perhaps not).

And then you do one of the following, depending on what works:

1) Put separate overrides for Voice.Glissando and TabVoice.Glissando

2) Put in a check for the type of context, and choose the correct override.


Then you put \include "string-instruments.ly" at the top of your snippet,
and it's good to go.

Thanks,

Carl

[c_sorensen, 2010-12-11 20:16:25]

On 12/11/10 12:55 PM, "Carl Sorensen" <c_sorensen@byu.edu> wrote:

> 
> 
> 
> On 12/11/10 12:44 PM, "Patrick Schmidt" <p.l.schmidt@gmx.de> wrote:
> 
>> 
>> 
>> Am 11.12.2010 um 18:03 schrieb Carl Sorensen:
>> 
>>> On 12/11/10 9:54 AM, "Patrick Schmidt" <p.l.schmidt@gmx.de> wrote:
>>> 
>>>> IMHO I think we want to have \hideNotes apply to TabVoice. I tried to
>>>> achieve glissandi with an indefinite beginning/ending (but in vain):
>>> 
>>> You can test this really easily.
>>> 
>>> 
>>> Simply add
>>> 
>>> \override TabNoteHead #'transparent = ##t
>>> 
>>> after line 233 of ly/property-init.ly, and
>>> 
>>> \revert TabNoteHead #'transparent
>>> 
>>> after line 243 of ly/property-init.ly
>>> 
>>> You could do so, and make it part of this patch.
>>> 
>>> Thanks,
>>> 
>>> Carl
>> 
>> Wow, that was easy! Unfortunately some overrides are necessary in
>> order to make the glissandi look half decent. The problem is that it
>> seems to be impossible to find an optimal setting for both staffs and
>> tab staffs. Without the overrides the slides are not visible in
>> normal staffs (not even with a 400 % zoom-in). With these overrides
>> glissandi are longer in TabStaffs than in Staffs. And because of
>> these overrides this snippet would have to go in selected snippets
>> rather than the body of the chapter?!
> 
> So perhaps what you do is put this (along with the \chordGlissando) function
> in a file ly/string-instruments.ly.
> 

Since Graham has suggested this for chordGlissando, I'll take care of adding
ly/string-instruments.ly.

Thanks,

Carl

[pls, 2010-12-11 20:35:53]

Am 11.12.2010 um 21:16 schrieb Carl Sorensen:

> On 12/11/10 12:55 PM, "Carl Sorensen" <c_sorensen@byu.edu> wrote:
>
>>
>>
>>
>> On 12/11/10 12:44 PM, "Patrick Schmidt" <p.l.schmidt@gmx.de> wrote:
>>
>>>
>>>
>>> Am 11.12.2010 um 18:03 schrieb Carl Sorensen:
>>>
>>>> On 12/11/10 9:54 AM, "Patrick Schmidt" <p.l.schmidt@gmx.de> wrote:
>>>>
>>>>> IMHO I think we want to have \hideNotes apply to TabVoice. I  
>>>>> tried to
>>>>> achieve glissandi with an indefinite beginning/ending (but in  
>>>>> vain):
>>>>
>>>> You can test this really easily.
>>>>
>>>>
>>>> Simply add
>>>>
>>>> \override TabNoteHead #'transparent = ##t
>>>>
>>>> after line 233 of ly/property-init.ly, and
>>>>
>>>> \revert TabNoteHead #'transparent
>>>>
>>>> after line 243 of ly/property-init.ly
>>>>
>>>> You could do so, and make it part of this patch.
>>>>
>>>> Thanks,
>>>>
>>>> Carl
>>>
>>> Wow, that was easy! Unfortunately some overrides are necessary in
>>> order to make the glissandi look half decent. The problem is that it
>>> seems to be impossible to find an optimal setting for both staffs  
>>> and
>>> tab staffs. Without the overrides the slides are not visible in
>>> normal staffs (not even with a 400 % zoom-in). With these overrides
>>> glissandi are longer in TabStaffs than in Staffs. And because of
>>> these overrides this snippet would have to go in selected snippets
>>> rather than the body of the chapter?!
>>
>> So perhaps what you do is put this (along with the  
>> \chordGlissando) function
>> in a file ly/string-instruments.ly.
>>
>
> Since Graham has suggested this for chordGlissando, I'll take care  
> of adding
> ly/string-instruments.ly.
I think it is a good solution to put \chordGlissando in a file to be  
included.

I wouldn't mind to do this myself. I could try to find out the  
optimal settings for Voice and TabVoice and create a \slide-function.  
But you are probably faster...

Thanks,

patrick
>
> Thanks,
>
> Carl
>

[c_sorensen, 2010-12-11 20:41:43]

On 12/11/10 1:35 PM, "Patrick Schmidt" <p.l.schmidt@gmx.de> wrote:

> 
> 
> Am 11.12.2010 um 21:16 schrieb Carl Sorensen:
> 
>> On 12/11/10 12:55 PM, "Carl Sorensen" <c_sorensen@byu.edu> wrote:
>> 
>>> 
>>> 
>>> 
>>> On 12/11/10 12:44 PM, "Patrick Schmidt" <p.l.schmidt@gmx.de> wrote:
>>> 
>>>> 
>>>> 
>>>> Am 11.12.2010 um 18:03 schrieb Carl Sorensen:
>>>> 
>>>>> On 12/11/10 9:54 AM, "Patrick Schmidt" <p.l.schmidt@gmx.de> wrote:
>>>>> 
>>>>>> IMHO I think we want to have \hideNotes apply to TabVoice. I
>>>>>> tried to
>>>>>> achieve glissandi with an indefinite beginning/ending (but in
>>>>>> vain):
>>>>> 
>>>>> You can test this really easily.
>>>>> 
>>>>> 
>>>>> Simply add
>>>>> 
>>>>> \override TabNoteHead #'transparent = ##t
>>>>> 
>>>>> after line 233 of ly/property-init.ly, and
>>>>> 
>>>>> \revert TabNoteHead #'transparent
>>>>> 
>>>>> after line 243 of ly/property-init.ly
>>>>> 
>>>>> You could do so, and make it part of this patch.
>>>>> 
>>>>> Thanks,
>>>>> 
>>>>> Carl
>>>> 
>>>> Wow, that was easy! Unfortunately some overrides are necessary in
>>>> order to make the glissandi look half decent. The problem is that it
>>>> seems to be impossible to find an optimal setting for both staffs
>>>> and
>>>> tab staffs. Without the overrides the slides are not visible in
>>>> normal staffs (not even with a 400 % zoom-in). With these overrides
>>>> glissandi are longer in TabStaffs than in Staffs. And because of
>>>> these overrides this snippet would have to go in selected snippets
>>>> rather than the body of the chapter?!
>>> 
>>> So perhaps what you do is put this (along with the
>>> \chordGlissando) function
>>> in a file ly/string-instruments.ly.
>>> 
>> 
>> Since Graham has suggested this for chordGlissando, I'll take care
>> of adding
>> ly/string-instruments.ly.
> I think it is a good solution to put \chordGlissando in a file to be
> included.
> 
> I wouldn't mind to do this myself. I could try to find out the
> optimal settings for Voice and TabVoice and create a \slide-function.
> But you are probably faster...

If you want to do this, by all means do so.  I might be faster, but if
you're doing it, then I can work on critical issues instead.

Here's a copy of ly/string-instruments-init.ly to get you started.  Also, a
copy of input/regression/tablature-chord-glissando.ly.


Thanks,

Carl

[Graham Percival (old account), 2011-01-22 20:08:47]

It looks like there's lots of good work in this patch, but the latest version
seems to have some mixed patches.  Could you try updating your git tree, then
try uploading a new patch?

If you need help with git (or with lily-git.tcl), then please don't hesitate to
ask.

http://codereview.appspot.com/3590041/diff/11001/Documentation/notation/rhyth...
File Documentation/notation/rhythms.itely (right):

http://codereview.appspot.com/3590041/diff/11001/Documentation/notation/rhyth...
Documentation/notation/rhythms.itely:1178: Metronome marks may also be printed
as a range of two numbers:
It looks like this patchset contains multiple patches -- I don't see what
metronome marks have to do with harmonics.

http://codereview.appspot.com/3590041/diff/11001/lily/optimal-page-breaking.cc
File lily/optimal-page-breaking.cc (left):

http://codereview.appspot.com/3590041/diff/11001/lily/optimal-page-breaking.c...
lily/optimal-page-breaking.cc:62: if (systems_per_page () > 0)
Is this another accidental change?  I'm not certain that this should be part of
the harmonic+slides patch.

http://codereview.appspot.com/3590041/diff/11001/lily/page-breaking.cc
File lily/page-breaking.cc (right):

http://codereview.appspot.com/3590041/diff/11001/lily/page-breaking.cc#newcod...
lily/page-breaking.cc:1141: return space_systems_with_fixed_number_per_page
(configuration, first_page_num);
Ditto.

[pls, 2011-01-22 20:17:05]

Sounds like there is something wrong with this patch. I will have a  
look at it, tomorrow.

patrick
Am 22.01.2011 um 21:08 schrieb percival.music.ca@gmail.com:

> It looks like there's lots of good work in this patch, but the latest
> version seems to have some mixed patches.  Could you try updating your
> git tree, then try uploading a new patch?
>
> If you need help with git (or with lily-git.tcl), then please don't
> hesitate to ask.
>
>
> http://codereview.appspot.com/3590041/diff/11001/Documentation/ 
> notation/rhythms.itely
> File Documentation/notation/rhythms.itely (right):
>
> http://codereview.appspot.com/3590041/diff/11001/Documentation/ 
> notation/rhythms.itely#newcode1178
> Documentation/notation/rhythms.itely:1178: Metronome marks may also be
> printed as a range of two numbers:
> It looks like this patchset contains multiple patches -- I don't see
> what metronome marks have to do with harmonics.
>
> http://codereview.appspot.com/3590041/diff/11001/lily/optimal-page- 
> breaking.cc
> File lily/optimal-page-breaking.cc (left):
>
> http://codereview.appspot.com/3590041/diff/11001/lily/optimal-page- 
> breaking.cc#oldcode62
> lily/optimal-page-breaking.cc:62: if (systems_per_page () > 0)
> Is this another accidental change?  I'm not certain that this  
> should be
> part of the harmonic+slides patch.
>
> http://codereview.appspot.com/3590041/diff/11001/lily/page-breaking.cc
> File lily/page-breaking.cc (right):
>
> http://codereview.appspot.com/3590041/diff/11001/lily/page- 
> breaking.cc#newcode1141
> lily/page-breaking.cc:1141: return
> space_systems_with_fixed_number_per_page (configuration,
> first_page_num);
> Ditto.
>
> http://codereview.appspot.com/3590041/

[pls, 2011-01-29 11:09:34]

Hi Graham,

I haven't forgotten this patch but unfortunately I don't seem to find  
time to fix it at the moment. It seems as if two patches got mixed up  
at least. So I'm probably not responsible for the good stuff! ;-(
I can't promise but I'll try to take care of it next weekend.

Thanks,
patrick
Am 22.01.2011 um 21:08 schrieb percival.music.ca@gmail.com:

> It looks like there's lots of good work in this patch, but the latest
> version seems to have some mixed patches.  Could you try updating your
> git tree, then try uploading a new patch?
>
> If you need help with git (or with lily-git.tcl), then please don't
> hesitate to ask.
>
>
> http://codereview.appspot.com/3590041/diff/11001/Documentation/ 
> notation/rhythms.itely
> File Documentation/notation/rhythms.itely (right):
>
> http://codereview.appspot.com/3590041/diff/11001/Documentation/ 
> notation/rhythms.itely#newcode1178
> Documentation/notation/rhythms.itely:1178: Metronome marks may also be
> printed as a range of two numbers:
> It looks like this patchset contains multiple patches -- I don't see
> what metronome marks have to do with harmonics.
>
> http://codereview.appspot.com/3590041/diff/11001/lily/optimal-page- 
> breaking.cc
> File lily/optimal-page-breaking.cc (left):
>
> http://codereview.appspot.com/3590041/diff/11001/lily/optimal-page- 
> breaking.cc#oldcode62
> lily/optimal-page-breaking.cc:62: if (systems_per_page () > 0)
> Is this another accidental change?  I'm not certain that this  
> should be
> part of the harmonic+slides patch.
>
> http://codereview.appspot.com/3590041/diff/11001/lily/page-breaking.cc
> File lily/page-breaking.cc (right):
>
> http://codereview.appspot.com/3590041/diff/11001/lily/page- 
> breaking.cc#newcode1141
> lily/page-breaking.cc:1141: return
> space_systems_with_fixed_number_per_page (configuration,
> first_page_num);
> Ditto.
>
> http://codereview.appspot.com/3590041/

[Graham Percival (old account), 2011-02-14 22:22:05]

This issue should be closed; a new patch is at:
http://codereview.appspot.com/4186049/