code review 357043: fmt: enable the complex tests now that 8g supports complex

fmt: enable the complex tests now that 8g supports complex

[r, 2010-03-09 21:54:40]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-03-09 21:57:00]

LGTM

assuming you've run all.bash with GOARCH=386

On Tue, Mar 9, 2010 at 13:54,  <r@golang.org> wrote:
> Reviewers: rsc,
>
> Message:
> Hello rsc (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> fmt: enable the complex tests now that 8g supports complex
>
> Please review this at http://codereview.appspot.com/357043/show
>
> Affected files:
>  M src/pkg/fmt/fmt_test.go
>
>
> Index: src/pkg/fmt/fmt_test.go
> ===================================================================
> --- a/src/pkg/fmt/fmt_test.go
> +++ b/src/pkg/fmt/fmt_test.go
> @@ -119,7 +119,6 @@
>        fmtTest{"% .3g", -1.0, "-1"},
>        fmtTest{"% .3g", 1.0, " 1"},
>
> -       /* TODO: Enable when complex support is in all compilers
>        // complex values
>        fmtTest{"%+.3e", 0i, "(+0.000e+00+0.000e+00i)"},
>        fmtTest{"%+.3f", 0i, "(+0.000+0.000i)"},
> @@ -139,7 +138,6 @@
>        fmtTest{"% .3E", -1 - 2i, "(-1.000E+00-2.000E+00i)"},
>        fmtTest{"%+.3g", complex64(1 + 2i), "(+1+2i)"},
>        fmtTest{"%+.3g", complex128(1 + 2i), "(+1+2i)"},
> -       */
>
>        // erroneous formats
>        fmtTest{"", 2, "?(extra int=2)"},
> @@ -232,12 +230,10 @@
>        fmtTest{"%v", &array, "&[1 2 3 4 5]"},
>        fmtTest{"%v", &iarray, "&[1 hello 2.5 <nil>]"},
>
> -       /* TODO: Enable when complex support is in all compilers
>        // complexes with %v
>        fmtTest{"%v", 1 + 2i, "(1+2i)"},
>        fmtTest{"%v", complex64(1 + 2i), "(1+2i)"},
>        fmtTest{"%v", complex128(1 + 2i), "(1+2i)"},
> -       */
>
>        // structs
>        fmtTest{"%v", A{1, 2, "a", []int{1, 2}}, `{1 2 a [1 2]}`},
>
>
>

[r, 2010-03-09 22:17:17]

*** Submitted as http://code.google.com/p/go/source/detail?r=0741e65a12be ***

fmt: enable the complex tests now that 8g supports complex

R=rsc
CC=golang-dev
http://codereview.appspot.com/357043