Issue 3563042: code review 3563042: gc: align structs according to max alignment of fields

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3563042: code review 3563042: gc: align structs according to max alignment of fields (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by rsc

Modified:
14 years, 4 months ago

Reviewers:

CC:
ken2, r, golang-dev

Visibility:
Public.

Description

gc: align structs according to max alignment of fields cc: same runtime: test cc alignment (required moving #define of offsetof to runtime.h) fix bug260 Fixes issue 482. Fixes issue 609.

Patch Set 1 #

Patch Set 2 : code review 3563042: gc: align structs according to max alignment of fields #

Patch Set 3 : code review 3563042: gc: align structs according to max alignment of fields #

Patch Set 4 : code review 3563042: gc: align structs according to max alignment of fields #

Patch Set 5 : code review 3563042: gc: align structs according to max alignment of fields #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+148 lines, -91 lines)			Patch
M	src/cmd/5c/swt.c	View	1 2 3	5 chunks	+20 lines, -10 lines	0 comments	Download
M	src/cmd/5c/txt.c	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/cmd/6c/cgen.c	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/6c/swt.c	View		5 chunks	+17 lines, -10 lines	0 comments	Download
M	src/cmd/6c/txt.c	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/cmd/8c/cgen64.c	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/8c/swt.c	View	1 2 3	5 chunks	+20 lines, -10 lines	0 comments	Download
M	src/cmd/8c/txt.c	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/cmd/cc/cc.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	src/cmd/cc/dcl.c	View		8 chunks	+16 lines, -13 lines	0 comments	Download
M	src/cmd/cc/pgen.c	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/cmd/cc/pswt.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/align.c	View		3 chunks	+7 lines, -3 lines	0 comments	Download
M	src/cmd/gc/typecheck.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/reflect/value.go	View		4 chunks	+5 lines, -7 lines	0 comments	Download
M	src/pkg/runtime/debug.go	View	4	2 chunks	+11 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/hashmap.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/runtime/malloc.goc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/runtime/runtime.c	View		2 chunks	+10 lines, -1 line	0 comments	Download
M	test/fixedbugs/bug260.go	View	1 2	4 chunks	+12 lines, -6 lines	0 comments	Download
M	test/golden.out	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2, r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 4 months ago (2010-12-13 18:17:49 UTC) #1

rsc

14 years, 4 months ago (2010-12-13 21:22:25 UTC) #3

*** Submitted as 86117a6f54fe ***

gc: align structs according to max alignment of fields
cc: same
runtime: test cc alignment (required moving #define of offsetof to runtime.h)
fix bug260

Fixes issue 482.
Fixes issue 609.

R=ken2, r
CC=golang-dev
http://codereview.appspot.com/3563042

Expand All Messages | Collapse All Messages