Issue 3529041: code review 3529041: throughout: simplify two-variable ranges with unused se...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3529041: code review 3529041: throughout: simplify two-variable ranges with unused se... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by rmmh

Modified:
14 years, 7 months ago

Reviewers:

CC:
golang-dev, gri

Visibility:
Public.

Description

throughout: simplify two-variable ranges with unused second variable

Patch Set 1 #

Patch Set 2 : code review 3529041: throughout: simplify two-variable ranges with unused se... #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -10 lines)			Patch
M	src/cmd/godoc/godoc.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/container/vector/numbers_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/draw/draw.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/go/parser/parser_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/http/transfer.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/index/suffixarray/suffixarray.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/reflect/type.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/unicode/maketables.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/blank.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rmmh

Hello golang-dev@googlegroups.com, I'd like you to review this change.

14 years, 7 months ago (2010-12-09 03:18:36 UTC) #1

gri

LGTM thanks - gri On Wed, Dec 8, 2010 at 7:18 PM, <hitchmanr@gmail.com> wrote: > ...

14 years, 7 months ago (2010-12-09 05:35:31 UTC) #2

gri

LGTM thanks - gri On Wed, Dec 8, 2010 at 7:18 PM, <hitchmanr@gmail.com> wrote: > ...

14 years, 7 months ago (2010-12-09 05:36:39 UTC) #3

gri

14 years, 7 months ago (2010-12-09 05:37:01 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=a5eebdd09522 ***

throughout: simplify two-variable ranges with unused second variable

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/3529041

Committer: Robert Griesemer <gri@golang.org>

Expand All Messages | Collapse All Messages